Merge pull request #6 from mirror3000/master

Fix warnings (compiling with clang++ -Wall)
This commit is contained in:
Arun Muralidharan 2017-08-20 10:39:44 +05:30 committed by GitHub
commit b012256919

View File

@ -146,7 +146,7 @@ namespace util
* to be split. Default constructed to ' '(space) and '\t'(tab) * to be split. Default constructed to ' '(space) and '\t'(tab)
* [out] vector<string> : Vector of strings split at deleimiter. * [out] vector<string> : Vector of strings split at deleimiter.
*/ */
static std::vector<std::string> static inline std::vector<std::string>
split(const std::string& str, const std::string& delims=" \t") split(const std::string& str, const std::string& delims=" \t")
{ {
std::vector<std::string> res; std::vector<std::string> res;
@ -932,7 +932,7 @@ private:
class Popen class Popen
{ {
public: public:
friend class detail::ArgumentDeducer; friend struct detail::ArgumentDeducer;
friend class detail::Child; friend class detail::Child;
template <typename... Args> template <typename... Args>
@ -1179,7 +1179,6 @@ void Popen::execute_process() throw (CalledProcessError, OSError)
} }
else else
{ {
int sys_ret = -1;
close (err_wr_pipe);// close child side of pipe, else get stuck in read below close (err_wr_pipe);// close child side of pipe, else get stuck in read below
stream_.close_child_fds(); stream_.close_child_fds();