From 04119a91f8407980eac00c3e2374ef398998a91e Mon Sep 17 00:00:00 2001 From: Marcus Holland-Moritz Date: Sat, 27 Apr 2024 08:59:10 +0200 Subject: [PATCH] fix: don't unnecessarily call value_parser twice --- include/dwarfs/compression_metadata_requirements.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/dwarfs/compression_metadata_requirements.h b/include/dwarfs/compression_metadata_requirements.h index 0fbdf650..1840e72b 100644 --- a/include/dwarfs/compression_metadata_requirements.h +++ b/include/dwarfs/compression_metadata_requirements.h @@ -92,7 +92,7 @@ bool parse_metadata_requirements_set(T& container, folly::dynamic& req, v.asString(), name, e.what())); } - if (auto maybe_value = value_parser(v)) { + if (maybe_value) { if (!container.emplace(*maybe_value).second) { throw std::runtime_error(fmt::format( "duplicate value '{}' for requirement '{}'", v.asString(), name));