TheCloud/dwarfs
1
0
Fork 0
mirror of https://github.com/mhx/dwarfs.git synced 2025-09-08 20:12:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove internal methods from public interface

Browse Source
This commit is contained in:
Marcus Holland-Moritz 2024-08-20 22:36:49 +02:00
parent e6d69866a3
commit 0e3ceb0b30
3 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/dwarfs/reader/metadata_types.h
View File

@ -96,10 +96,6 @@ class dir_entry_view {
std::filesystem::path fs_path() const; std::filesystem::path fs_path() const;
std::wstring wpath() const; std::wstring wpath() const;
void append_to(std::filesystem::path& p) const;
uint32_t self_index() const;
internal::dir_entry_view_impl const& raw() const { return *impl_; } internal::dir_entry_view_impl const& raw() const { return *impl_; }
private: private:

7
src/reader/internal/metadata_v2.cpp
View File

@ -1171,8 +1171,8 @@ void metadata_<LoggerPolicy>::dump(
os << " (" << count << " entries, parent=" << dir.parent_entry() << ")\n"; os << " (" << count << " entries, parent=" << dir.parent_entry() << ")\n";
for (size_t i = 0; i < count; ++i) { for (size_t i = 0; i < count; ++i) {
dump(os, indent, make_dir_entry_view(first + i, entry.self_index()), opts, dump(os, indent, make_dir_entry_view(first + i, entry.raw().self_index()),
icb); opts, icb);
} }
} }
@ -1328,7 +1328,8 @@ nlohmann::json metadata_<LoggerPolicy>::as_json(directory_view dir,
auto first = dir.first_entry(); auto first = dir.first_entry();
for (size_t i = 0; i < count; ++i) { for (size_t i = 0; i < count; ++i) {
arr.push_back(as_json(make_dir_entry_view(first + i, entry.self_index()))); arr.push_back(
as_json(make_dir_entry_view(first + i, entry.raw().self_index())));
} }
return arr; return arr;

6
src/reader/metadata_types.cpp
View File

@ -87,12 +87,6 @@ std::filesystem::path dir_entry_view::fs_path() const {
std::wstring dir_entry_view::wpath() const { return impl_->wpath(); } std::wstring dir_entry_view::wpath() const { return impl_->wpath(); }
void dir_entry_view::append_to(std::filesystem::path& p) const {
impl_->append_to(p);
}
uint32_t dir_entry_view::self_index() const { return impl_->self_index(); }
uint32_t directory_view::first_entry(uint32_t ino) const { uint32_t directory_view::first_entry(uint32_t ino) const {
return g_->first_dir_entry(ino); return g_->first_dir_entry(ino);
} }