TheCloud/dwarfs
1
0
Fork 0
mirror of https://github.com/mhx/dwarfs.git synced 2025-09-12 05:49:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore(tools_test): retry umount on macOS

Browse Source 
We've seen some spurious failures to unmount a FUSE volume due to
the volume still being busy. Not sure if this fixes it, but worth
a try.
This commit is contained in:
Marcus Holland-Moritz 2024-02-01 15:27:58 +01:00
parent 314d7074ab
commit 17a74390c8
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
test/tools_test.cpp
View File

@ -578,7 +578,22 @@ class driver_runner {
if (!umount) { if (!umount) {
throw std::runtime_error("no umount binary found"); throw std::runtime_error("no umount binary found");
} }
subprocess::check_run(umount.value(), mountpoint_); auto t0 = std::chrono::steady_clock::now();
for (;;) {
auto [out, err, ec] = subprocess::run(umount.value(), mountpoint_);
if (ec == 0) {
break;
}
std::cerr << "driver failed to unmount:\nout:\n"
<< out << "err:\n"
<< err << "exit code: " << ec << "\n";
if (std::chrono::steady_clock::now() - t0 > std::chrono::seconds(5)) {
throw std::runtime_error(
"driver still failed to unmount after 5 seconds");
}
std::cerr << "retrying...\n";
std::this_thread::sleep_for(std::chrono::milliseconds(10));
}
bool rv{true}; bool rv{true};
if (process_) { if (process_) {
process_->wait(); process_->wait();