From 1f20b02b6897a4fbf70b497b98f633ae62ccfc1e Mon Sep 17 00:00:00 2001 From: Marcus Holland-Moritz Date: Sat, 6 Mar 2021 14:39:38 +0100 Subject: [PATCH] Finalize classes --- src/dwarfs/block_cache.cpp | 2 +- src/dwarfs/block_manager.cpp | 2 +- src/dwarfs/filesystem_extractor.cpp | 2 +- src/dwarfs/filesystem_v2.cpp | 2 +- src/dwarfs/filesystem_writer.cpp | 2 +- src/dwarfs/inode_manager.cpp | 2 +- src/dwarfs/inode_reader_v2.cpp | 2 +- src/dwarfs/metadata_v2.cpp | 2 +- src/dwarfs/scanner.cpp | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/dwarfs/block_cache.cpp b/src/dwarfs/block_cache.cpp index 47bde1ed..0b8e5f79 100644 --- a/src/dwarfs/block_cache.cpp +++ b/src/dwarfs/block_cache.cpp @@ -199,7 +199,7 @@ class block_request_set { // multi-threaded block cache template -class block_cache_ : public block_cache::impl { +class block_cache_ final : public block_cache::impl { public: block_cache_(logger& lgr, std::shared_ptr mm, block_cache_options const& options) diff --git a/src/dwarfs/block_manager.cpp b/src/dwarfs/block_manager.cpp index 652fd96f..176ba324 100644 --- a/src/dwarfs/block_manager.cpp +++ b/src/dwarfs/block_manager.cpp @@ -179,7 +179,7 @@ class active_block { }; template -class block_manager_ : public block_manager::impl { +class block_manager_ final : public block_manager::impl { public: block_manager_(logger& lgr, progress& prog, const block_manager::config& cfg, std::shared_ptr os, filesystem_writer& fsw) diff --git a/src/dwarfs/filesystem_extractor.cpp b/src/dwarfs/filesystem_extractor.cpp index 128aed45..7b0a522b 100644 --- a/src/dwarfs/filesystem_extractor.cpp +++ b/src/dwarfs/filesystem_extractor.cpp @@ -68,7 +68,7 @@ class cache_semaphore { } // namespace template -class filesystem_extractor_ : public filesystem_extractor::impl { +class filesystem_extractor_ final : public filesystem_extractor::impl { public: filesystem_extractor_(logger& lgr) : log_{lgr} {} diff --git a/src/dwarfs/filesystem_v2.cpp b/src/dwarfs/filesystem_v2.cpp index fd0adac6..2e78e416 100644 --- a/src/dwarfs/filesystem_v2.cpp +++ b/src/dwarfs/filesystem_v2.cpp @@ -173,7 +173,7 @@ make_metadata(logger& lgr, std::shared_ptr mm, } template -class filesystem_ : public filesystem_v2::impl { +class filesystem_ final : public filesystem_v2::impl { public: filesystem_(logger& lgr_, std::shared_ptr mm, const filesystem_options& options, diff --git a/src/dwarfs/filesystem_writer.cpp b/src/dwarfs/filesystem_writer.cpp index d47f42ed..eaf740db 100644 --- a/src/dwarfs/filesystem_writer.cpp +++ b/src/dwarfs/filesystem_writer.cpp @@ -203,7 +203,7 @@ fsblock::fsblock(section_type type, compression_type compression, : impl_(std::make_unique(type, compression, data)) {} template -class filesystem_writer_ : public filesystem_writer::impl { +class filesystem_writer_ final : public filesystem_writer::impl { public: filesystem_writer_(logger& lgr, std::ostream& os, worker_group& wg, progress& prog, const block_compressor& bc, diff --git a/src/dwarfs/inode_manager.cpp b/src/dwarfs/inode_manager.cpp index 644c6092..3b520131 100644 --- a/src/dwarfs/inode_manager.cpp +++ b/src/dwarfs/inode_manager.cpp @@ -172,7 +172,7 @@ class nilsimsa_cache_entry { } // namespace template -class inode_manager_ : public inode_manager::impl { +class inode_manager_ final : public inode_manager::impl { public: inode_manager_(logger& lgr, progress& prog) : LOG_PROXY_INIT(lgr) diff --git a/src/dwarfs/inode_reader_v2.cpp b/src/dwarfs/inode_reader_v2.cpp index 93483f0a..7c2ae7c4 100644 --- a/src/dwarfs/inode_reader_v2.cpp +++ b/src/dwarfs/inode_reader_v2.cpp @@ -42,7 +42,7 @@ namespace dwarfs { namespace { template -class inode_reader_ : public inode_reader_v2::impl { +class inode_reader_ final : public inode_reader_v2::impl { public: inode_reader_(logger& lgr, block_cache&& bc) : cache_(std::move(bc)) diff --git a/src/dwarfs/metadata_v2.cpp b/src/dwarfs/metadata_v2.cpp index e38ab267..cd33c124 100644 --- a/src/dwarfs/metadata_v2.cpp +++ b/src/dwarfs/metadata_v2.cpp @@ -104,7 +104,7 @@ const uint16_t READ_ONLY_MASK = ~(S_IWUSR | S_IWGRP | S_IWOTH); } // namespace template -class metadata_ : public metadata_v2::impl { +class metadata_ final : public metadata_v2::impl { public: // TODO: defaults?, remove metadata_(logger& lgr, folly::ByteRange schema, folly::ByteRange data, diff --git a/src/dwarfs/scanner.cpp b/src/dwarfs/scanner.cpp index ac59f81f..7a80ec14 100644 --- a/src/dwarfs/scanner.cpp +++ b/src/dwarfs/scanner.cpp @@ -294,7 +294,7 @@ std::string status_string(progress const& p, size_t width) { } // namespace template -class scanner_ : public scanner::impl { +class scanner_ final : public scanner::impl { public: scanner_(logger& lgr, worker_group& wg, const block_manager::config& config, std::shared_ptr ef, std::shared_ptr os,