diff --git a/src/dwarfs/categorizer.cpp b/src/dwarfs/categorizer.cpp index c83f114a..44450dd9 100644 --- a/src/dwarfs/categorizer.cpp +++ b/src/dwarfs/categorizer.cpp @@ -219,7 +219,7 @@ categorizer_job::categorizer_job(std::unique_ptr impl) template class categorizer_manager_ final : public categorizer_manager_private { public: - categorizer_manager_(logger& lgr) + explicit categorizer_manager_(logger& lgr) : lgr_{lgr} , LOG_PROXY_INIT(lgr) { add_category(categorizer::DEFAULT_CATEGORY, diff --git a/src/dwarfs/categorizer/binary_categorizer.cpp b/src/dwarfs/categorizer/binary_categorizer.cpp index edd5c71a..3de1d23e 100644 --- a/src/dwarfs/categorizer/binary_categorizer.cpp +++ b/src/dwarfs/categorizer/binary_categorizer.cpp @@ -55,7 +55,7 @@ class binary_categorizer_base : public random_access_categorizer { template class binary_categorizer_ final : public binary_categorizer_base { public: - binary_categorizer_(logger& lgr) + explicit binary_categorizer_(logger& lgr) : LOG_PROXY_INIT(lgr) {} inode_fragments diff --git a/src/dwarfs/categorizer/libmagic_categorizer.cpp b/src/dwarfs/categorizer/libmagic_categorizer.cpp index beaf1097..f9920130 100644 --- a/src/dwarfs/categorizer/libmagic_categorizer.cpp +++ b/src/dwarfs/categorizer/libmagic_categorizer.cpp @@ -94,7 +94,7 @@ class magic_wrapper { class scoped_cookie { public: - scoped_cookie(magic_wrapper const& w) + explicit scoped_cookie(magic_wrapper const& w) : cookie_{get_scoped_cookie(w)} , w_{w} {} diff --git a/src/dwarfs/categorizer/pcmaudio_categorizer.cpp b/src/dwarfs/categorizer/pcmaudio_categorizer.cpp index bc0cd1eb..645a5b85 100644 --- a/src/dwarfs/categorizer/pcmaudio_categorizer.cpp +++ b/src/dwarfs/categorizer/pcmaudio_categorizer.cpp @@ -449,7 +449,7 @@ class pcmaudio_categorizer_base : public random_access_categorizer { template class pcmaudio_categorizer_ final : public pcmaudio_categorizer_base { public: - pcmaudio_categorizer_(logger& lgr) + explicit pcmaudio_categorizer_(logger& lgr) : LOG_PROXY_INIT(lgr) { waveform_req_.add_set("endianness", &pcmaudio_metadata::sample_endianness, parse_endianness_dyn); diff --git a/src/dwarfs/compression/flac.cpp b/src/dwarfs/compression/flac.cpp index eb212323..c4b5ab5d 100644 --- a/src/dwarfs/compression/flac.cpp +++ b/src/dwarfs/compression/flac.cpp @@ -53,7 +53,7 @@ constexpr size_t const kBlockSize{65536}; class dwarfs_flac_stream_encoder : public FLAC::Encoder::Stream { public: - dwarfs_flac_stream_encoder(std::vector& data) + explicit dwarfs_flac_stream_encoder(std::vector& data) : data_{data} , pos_{data_.size()} {} diff --git a/src/dwarfs/filesystem_writer.cpp b/src/dwarfs/filesystem_writer.cpp index 253da704..6f8d6b26 100644 --- a/src/dwarfs/filesystem_writer.cpp +++ b/src/dwarfs/filesystem_writer.cpp @@ -136,7 +136,7 @@ class fsblock { class fsblock_merger_policy { public: - fsblock_merger_policy(size_t worst_case_block_size) + explicit fsblock_merger_policy(size_t worst_case_block_size) : worst_case_block_size_{worst_case_block_size} {} size_t block_size(std::unique_ptr const& fsb) const { diff --git a/src/dwarfs/pcm_sample_transformer.cpp b/src/dwarfs/pcm_sample_transformer.cpp index a04cb4bd..2b8936e2 100644 --- a/src/dwarfs/pcm_sample_transformer.cpp +++ b/src/dwarfs/pcm_sample_transformer.cpp @@ -196,7 +196,7 @@ class pcm_sample_transformer_generic final public: using basic_transformer = basic_pcm_sample_transformer; - pcm_sample_transformer_generic(int bits) + explicit pcm_sample_transformer_generic(int bits) : bits_{bits} {} void unpack(std::span dst, diff --git a/src/dwarfs/segmenter.cpp b/src/dwarfs/segmenter.cpp index baebf3ae..94e230f6 100644 --- a/src/dwarfs/segmenter.cpp +++ b/src/dwarfs/segmenter.cpp @@ -341,7 +341,7 @@ class ConstantGranularityPolicy : private GranularityPolicyBase { class VariableGranularityPolicy : private GranularityPolicyBase { public: - VariableGranularityPolicy(uint32_t granularity) noexcept + explicit VariableGranularityPolicy(uint32_t granularity) noexcept : granularity_{granularity} {} template diff --git a/src/dwarfs/similarity_ordering.cpp b/src/dwarfs/similarity_ordering.cpp index ac1effbb..f7f60351 100644 --- a/src/dwarfs/similarity_ordering.cpp +++ b/src/dwarfs/similarity_ordering.cpp @@ -177,7 +177,7 @@ struct basic_cluster_tree_node { basic_cluster_tree_node() : v{std::make_unique()} {} - basic_cluster_tree_node(index_type&& index) + explicit basic_cluster_tree_node(index_type&& index) : v{std::make_unique(std::move(index))} {} children_vector const& children() const { diff --git a/src/mkdwarfs_main.cpp b/src/mkdwarfs_main.cpp index a34bb2d2..db8cf3ab 100644 --- a/src/mkdwarfs_main.cpp +++ b/src/mkdwarfs_main.cpp @@ -289,7 +289,7 @@ class categorize_optval { bool is_explicit{false}; categorize_optval() = default; - categorize_optval(std::string const& val, bool expl = false) + explicit categorize_optval(std::string const& val, bool expl = false) : value{val} , is_explicit{expl} {} diff --git a/test/block_merger_test.cpp b/test/block_merger_test.cpp index e06eb04b..65fd9d66 100644 --- a/test/block_merger_test.cpp +++ b/test/block_merger_test.cpp @@ -91,7 +91,8 @@ struct sized_block { class sized_block_merger_policy { public: - sized_block_merger_policy(std::vector&& worst_case_block_size) + explicit sized_block_merger_policy( + std::vector&& worst_case_block_size) : worst_case_block_size_{std::move(worst_case_block_size)} {} static size_t block_size(sized_block const& blk) { return blk.size; }