TheCloud/dwarfs
1
0
Fork 0
mirror of https://github.com/mhx/dwarfs.git synced 2025-09-17 00:10:03 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: tweak compute_best_split() to use bit-or instead of shift

Browse Source
This commit is contained in:
Marcus Holland-Moritz 2024-02-03 21:25:50 +01:00
parent afe34ed8cf
commit 43e4970a54
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ricepp/include/ricepp/detail/encode.h
View File

@ -34,14 +34,16 @@
namespace ricepp::detail { namespace ricepp::detail {
template <unsigned FsMax, typename T> template <unsigned FsMax, typename T>
requires std::unsigned_integral<typename T::value_type>
[[nodiscard]] std::pair<unsigned, unsigned> [[nodiscard]] std::pair<unsigned, unsigned>
compute_best_split(T const& delta, size_t size, uint64_t sum) noexcept { compute_best_split(T const& delta, size_t size, uint64_t sum) noexcept {
auto bits_for_fs = [&](auto fs) { auto bits_for_fs = [&](auto fs) {
auto bits = size * (fs + 1); auto const mask = std::numeric_limits<typename T::value_type>::max() << fs;
unsigned bits{0};
for (size_t i = 0; i < size; ++i) { for (size_t i = 0; i < size; ++i) {
bits += delta[i] >> fs; bits += delta[i] & mask;
} }
return bits; return size * (fs + 1) + (bits >> fs);
}; };
static constexpr auto const kMaxBits = std::numeric_limits<uint64_t>::digits; static constexpr auto const kMaxBits = std::numeric_limits<uint64_t>::digits;