From 4c6e652ba78820d04808b7b29a13017696e587af Mon Sep 17 00:00:00 2001
From: Marcus Holland-Moritz <github@mhxnet.de>
Date: Fri, 29 Aug 2025 15:35:22 +0200
Subject: [PATCH] test: add more hotness categorizer tests

---
 test/tool_mkdwarfs_main_build_test.cpp | 52 +++++++++++++++++++++++++-
 1 file changed, 51 insertions(+), 1 deletion(-)

diff --git a/test/tool_mkdwarfs_main_build_test.cpp b/test/tool_mkdwarfs_main_build_test.cpp
index 75e04c16..5ac1b912 100644
--- a/test/tool_mkdwarfs_main_build_test.cpp
+++ b/test/tool_mkdwarfs_main_build_test.cpp
@@ -996,7 +996,7 @@ TEST(mkdwarfs_test, hotness_categorizer) {
   t.fa->set_file("hot", hot_files.str());
 
   ASSERT_EQ(0, t.run({"-i", "/", "-o", image_file, "--categorize=hotness",
-                      "--hotness-list=hot", "-B0"}))
+                      "--hotness-list=hot", "-B0", "-l1", "--log-level=debug"}))
       << t.err();
 
   auto fs = t.fs_from_file(image_file);
@@ -1022,3 +1022,53 @@ TEST(mkdwarfs_test, hotness_categorizer) {
     EXPECT_EQ(info["chunks"][0]["category"].get<std::string>(), "<default>");
   }
 }
+
+TEST(mkdwarfs_test, hotness_categorizer_cannot_open_hotness_file) {
+  mkdwarfs_tester t;
+
+  EXPECT_NE(0, t.run({"-i", "/", "-o", "-", "--categorize=hotness",
+                      "--hotness-list=hot", "-B0"}))
+      << t.err();
+
+  EXPECT_THAT(t.err(), ::testing::HasSubstr("failed to open file 'hot':"));
+}
+
+TEST(mkdwarfs_test, hotness_categorizer_empty_hotness_list) {
+  mkdwarfs_tester t;
+
+  t.fa->set_file("hot", "");
+
+  EXPECT_EQ(0, t.run({"-i", "/", "-o", "-", "--categorize=hotness",
+                      "--hotness-list=hot", "-B0", "-l1"}))
+      << t.err();
+
+  EXPECT_THAT(t.err(),
+              ::testing::HasSubstr("hotness categorizer: empty hotness list"));
+}
+
+TEST(mkdwarfs_test, hotness_categorizer_no_hotness_list_provided) {
+  mkdwarfs_tester t;
+
+  EXPECT_EQ(0,
+            t.run({"-i", "/", "-o", "-", "--categorize=hotness", "-B0", "-l1"}))
+      << t.err();
+
+  EXPECT_THAT(t.err(), ::testing::HasSubstr(
+                           "hotness categorizer: no hotness list provided"));
+}
+
+TEST(mkdwarfs_test, hotness_categorizer_duplicate_path_in_hotness_list) {
+  std::ostringstream hot_files;
+  hot_files << "foo.pl" << '\n' << "ipsum.txt" << '\n' << "foo.pl" << '\n';
+
+  mkdwarfs_tester t;
+
+  t.fa->set_file("hot", hot_files.str());
+
+  EXPECT_NE(0, t.run({"-i", "/", "-o", "-", "--categorize=hotness",
+                      "--hotness-list=hot", "-B0"}))
+      << t.err();
+
+  EXPECT_THAT(t.err(),
+              ::testing::HasSubstr("duplicate path in hotness list: 'foo.pl'"));
+}