TheCloud/dwarfs
1
0
Fork 0
mirror of https://github.com/mhx/dwarfs.git synced 2025-09-12 13:59:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor(fragment_order_parser): use constexpr array instead of map

Browse Source
This commit is contained in:
Marcus Holland-Moritz 2024-12-03 21:16:30 +01:00
parent 1d12e081c7
commit 5202677d6c
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/writer/fragment_order_parser.cpp
View File

@ -19,12 +19,13 @@
* along with dwarfs. If not, see <https://www.gnu.org/licenses/>. * along with dwarfs. If not, see <https://www.gnu.org/licenses/>.
*/ */
#include <map> #include <array>
#include <stdexcept> #include <stdexcept>
#include <vector> #include <vector>
#include <fmt/format.h> #include <fmt/format.h>
#include <range/v3/algorithm/find.hpp>
#include <range/v3/range/conversion.hpp> #include <range/v3/range/conversion.hpp>
#include <range/v3/view/join.hpp> #include <range/v3/view/join.hpp>
#include <range/v3/view/map.hpp> #include <range/v3/view/map.hpp>
@ -36,13 +37,14 @@ namespace dwarfs::writer {
namespace { namespace {
const std::map<std::string_view, fragment_order_mode> order_choices{ std::array<std::pair<std::string_view, fragment_order_mode>,
5> constexpr order_choices{{
{"none", fragment_order_mode::NONE}, {"none", fragment_order_mode::NONE},
{"path", fragment_order_mode::PATH}, {"path", fragment_order_mode::PATH},
{"revpath", fragment_order_mode::REVPATH}, {"revpath", fragment_order_mode::REVPATH},
{"similarity", fragment_order_mode::SIMILARITY}, {"similarity", fragment_order_mode::SIMILARITY},
{"nilsimsa", fragment_order_mode::NILSIMSA}, {"nilsimsa", fragment_order_mode::NILSIMSA},
}; }};
} // namespace } // namespace
@ -63,7 +65,10 @@ fragment_order_parser::parse(std::string_view arg) const {
option_map om(arg); option_map om(arg);
auto algo = om.choice(); auto algo = om.choice();
if (auto it = order_choices.find(algo); it != order_choices.end()) { if (auto it = ranges::find(
order_choices, algo,
&std::pair<std::string_view, fragment_order_mode>::first);
it != order_choices.end()) {
rv.mode = it->second; rv.mode = it->second;
} else { } else {
throw std::runtime_error(fmt::format("invalid inode order mode: {}", algo)); throw std::runtime_error(fmt::format("invalid inode order mode: {}", algo));