From 72a69dd1e465d2f98ff34cb2f6c28caed2958a19 Mon Sep 17 00:00:00 2001 From: Marcus Holland-Moritz Date: Mon, 29 Jul 2024 13:00:07 +0200 Subject: [PATCH] chore(inode_reader): add TODO and move namespace scope --- src/dwarfs/internal/inode_reader_v2.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/dwarfs/internal/inode_reader_v2.cpp b/src/dwarfs/internal/inode_reader_v2.cpp index 8de9b1d1..6067c414 100644 --- a/src/dwarfs/internal/inode_reader_v2.cpp +++ b/src/dwarfs/internal/inode_reader_v2.cpp @@ -90,6 +90,8 @@ constexpr size_t const offset_cache_updater_max_inline_offsets = 4; constexpr size_t const offset_cache_size = 64; constexpr size_t const readahead_cache_size = 64; +} // namespace + template class inode_reader_ final : public inode_reader_v2::impl { public: @@ -295,6 +297,7 @@ inode_reader_::read_internal(uint32_t inode, size_t const size, size_t const copyoff = it->offset() + offset; size_t copysize = chunksize - offset; + // TODO: should this rather be an assertion? if (copysize == 0) { LOG_ERROR << "invalid zero-sized chunk"; ec = std::make_error_code(std::errc::invalid_argument); @@ -413,8 +416,6 @@ size_t inode_reader_::readv(iovec_read_buf& buf, uint32_t inode, return rv; } -} // namespace - inode_reader_v2::inode_reader_v2( logger& lgr, block_cache&& bc, inode_reader_options const& opts, std::shared_ptr perfmon)