From 736300697f3c20a8a7ea41bad435ac9de3dee127 Mon Sep 17 00:00:00 2001 From: Marcus Holland-Moritz Date: Wed, 20 Dec 2023 22:38:05 +0100 Subject: [PATCH] fix(flac): don't throw bad_compression error as this loses metadata --- src/dwarfs/compression/flac.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/dwarfs/compression/flac.cpp b/src/dwarfs/compression/flac.cpp index 372a3c7a..eb212323 100644 --- a/src/dwarfs/compression/flac.cpp +++ b/src/dwarfs/compression/flac.cpp @@ -331,9 +331,10 @@ class flac_block_compressor final : public block_compressor::impl { DWARFS_THROW(runtime_error, "[FLAC] failed to finish encoder"); } - if (compressed.size() >= data.size()) { - throw bad_compression_ratio_error(); - } + // XXX: don't throw this as we're losing metadata + // if (compressed.size() >= data.size()) { + // throw bad_compression_ratio_error(); + // } compressed.shrink_to_fit();