From 88425dd38f185bf60e5df9334f0552cd971111c8 Mon Sep 17 00:00:00 2001 From: Marcus Holland-Moritz Date: Sat, 2 Dec 2023 09:06:57 +0100 Subject: [PATCH] docs(metadata): rationale for using feature strings --- thrift/metadata.thrift | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/thrift/metadata.thrift b/thrift/metadata.thrift index 591f18e3..42c935d2 100644 --- a/thrift/metadata.thrift +++ b/thrift/metadata.thrift @@ -370,7 +370,9 @@ struct metadata { // The set of features used in this file system image. As long // as an older binary supports all features, it will be able - // to use images created with newer versions. + // to use images created with newer versions. We use strings + // here instead of an enum so older versions can still output + // names of features used by a newer version. 27: optional set features //=========================================================//