refactor(checksum): use array<string_view> instead of unordered_set<string>

This commit is contained in:
Marcus Holland-Moritz 2024-10-20 13:22:48 +02:00
parent ca69d2b141
commit 96e6cafdaa

View File

@ -25,7 +25,8 @@
#include <cstring> #include <cstring>
#include <functional> #include <functional>
#include <ostream> #include <ostream>
#include <unordered_set> #include <ranges>
#include <string_view>
#include <openssl/evp.h> #include <openssl/evp.h>
@ -42,9 +43,11 @@ namespace dwarfs {
namespace { namespace {
std::unordered_set<std::string> supported_algorithms{ using namespace std::string_view_literals;
"xxh3-64",
"xxh3-128", constexpr std::array supported_algorithms{
"xxh3-64"sv,
"xxh3-128"sv,
}; };
constexpr std::array unsupported_algorithms{ constexpr std::array unsupported_algorithms{
@ -207,7 +210,10 @@ bool verify_impl(T&& alg, void const* data, size_t size, const void* digest,
} // namespace } // namespace
bool checksum::is_available(std::string const& algo) { bool checksum::is_available(std::string const& algo) {
return supported_algorithms.count(algo) or checksum_evp::is_available(algo); // TODO: C++23: use std::ranges::contains
return std::ranges::find(supported_algorithms, algo) !=
supported_algorithms.end() ||
checksum_evp::is_available(algo);
} }
std::vector<std::string> checksum::available_algorithms() { std::vector<std::string> checksum::available_algorithms() {