From aa3e4902174dc44be1875c02f67b2e5814c1c02b Mon Sep 17 00:00:00 2001
From: Marcus Holland-Moritz <github@mhxnet.de>
Date: Sun, 9 Jul 2023 15:20:14 +0200
Subject: [PATCH] Ignore (presumably) false positive Flawfinder warnings

---
 src/mkdwarfs_main.cpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/mkdwarfs_main.cpp b/src/mkdwarfs_main.cpp
index 618fafec..8080f60e 100644
--- a/src/mkdwarfs_main.cpp
+++ b/src/mkdwarfs_main.cpp
@@ -906,8 +906,12 @@ int mkdwarfs_main(int argc, sys_char** argv) {
 
       std::vector<std::string_view> chmod_exprs;
       boost::split(chmod_exprs, chmod_str, boost::is_any_of(","));
-      auto mask = ::umask(0077);
-      ::umask(mask);
+
+      // I'm pretty certain these warnings by Flawfinder are false positives.
+      // After all, we're just doing a no-op by re-setting the original value
+      // in order to read it.
+      auto mask = ::umask(0077); /* Flawfinder: ignore */
+      ::umask(mask);             /* Flawfinder: ignore */
 
       for (auto expr : chmod_exprs) {
         bs->add_transformer(create_chmod_transformer(expr, mask));