From bdb5469b7bbe6fce672528d6a31bb8bd51a5b95d Mon Sep 17 00:00:00 2001
From: Marcus Holland-Moritz <github@mhxnet.de>
Date: Sun, 16 Mar 2025 10:29:50 +0100
Subject: [PATCH] refactor: use static_cast instead of reinterpret_cast

---
 include/dwarfs/mmif.h   |  6 ++++--
 src/compression/lz4.cpp | 10 +++++-----
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/include/dwarfs/mmif.h b/include/dwarfs/mmif.h
index 6dcca4c3..3875ee7c 100644
--- a/include/dwarfs/mmif.h
+++ b/include/dwarfs/mmif.h
@@ -22,6 +22,7 @@
 #pragma once
 
 #include <concepts>
+#include <cstddef>
 #include <filesystem>
 #include <span>
 #include <string>
@@ -47,8 +48,9 @@ class mmif : public boost::noncopyable {
 
   template <typename T, std::integral U>
   T const* as(U offset = 0) const {
-    return reinterpret_cast<T const*>(
-        reinterpret_cast<char const*>(this->addr()) + offset);
+    // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic)
+    auto raw = static_cast<std::byte const*>(this->addr()) + offset;
+    return static_cast<T const*>(static_cast<void const*>(raw));
   }
 
   template <typename T = uint8_t, std::integral U>
diff --git a/src/compression/lz4.cpp b/src/compression/lz4.cpp
index 379369a5..5300ad54 100644
--- a/src/compression/lz4.cpp
+++ b/src/compression/lz4.cpp
@@ -37,8 +37,8 @@ namespace {
 struct lz4_compression_policy {
   static size_t compress(const void* src, void* dest, size_t size,
                          size_t destsize, int /*level*/) {
-    return to<size_t>(LZ4_compress_default(reinterpret_cast<const char*>(src),
-                                           reinterpret_cast<char*>(dest),
+    return to<size_t>(LZ4_compress_default(static_cast<const char*>(src),
+                                           static_cast<char*>(dest),
                                            to<int>(size), to<int>(destsize)));
   }
 
@@ -48,9 +48,9 @@ struct lz4_compression_policy {
 struct lz4hc_compression_policy {
   static size_t compress(const void* src, void* dest, size_t size,
                          size_t destsize, int level) {
-    return to<size_t>(LZ4_compress_HC(reinterpret_cast<const char*>(src),
-                                      reinterpret_cast<char*>(dest),
-                                      to<int>(size), to<int>(destsize), level));
+    return to<size_t>(LZ4_compress_HC(static_cast<const char*>(src),
+                                      static_cast<char*>(dest), to<int>(size),
+                                      to<int>(destsize), level));
   }
 
   static std::string describe(int level) {