TheCloud/dwarfs
1
0
Fork 0
mirror of https://github.com/mhx/dwarfs.git synced 2025-09-11 21:35:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove --max-scanner-workers

Browse Source
This commit is contained in:
Marcus Holland-Moritz 2021-03-23 14:08:32 +01:00
parent 5bfabef613
commit c19c426968
2 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/mkdwarfs.md
View File

@ -67,13 +67,6 @@ Most other options are concerned with compression tuning:
to the number of processors available on your system. Use this option if to the number of processors available on your system. Use this option if
you want to limit the resources used by `mkdwarfs`. you want to limit the resources used by `mkdwarfs`.
* `-M`, `--max-scanner-workers=`*value*:
Maximum number of worker threads used for building the filesystem. This
defaults to the number of processors available on your system, but the
number of active workers will be automatically adjusted based on load.
With fast SSDs, scanning multiple files is probably fine, but with older
spinning disks, having less concurrency can improve overall speed.
* `-L`, `--memory-limit=`*value*: * `-L`, `--memory-limit=`*value*:
Approximately how much memory you want `mkdwarfs` to use during filesystem Approximately how much memory you want `mkdwarfs` to use during filesystem
creation. Note that currently this will only affect the block manager creation. Note that currently this will only affect the block manager

7
src/mkdwarfs.cpp
View File

@ -333,7 +333,7 @@ int mkdwarfs(int argc, char** argv) {
std::string path, output, memory_limit, script_arg, compression, std::string path, output, memory_limit, script_arg, compression,
schema_compression, metadata_compression, log_level_str, timestamp, schema_compression, metadata_compression, log_level_str, timestamp,
time_resolution, order, progress_mode, recompress_opts, pack_metadata; time_resolution, order, progress_mode, recompress_opts, pack_metadata;
size_t num_workers, max_scanner_workers; size_t num_workers;
bool no_progress = false, plain_string_tables = false; bool no_progress = false, plain_string_tables = false;
unsigned level; unsigned level;
uint16_t uid, gid; uint16_t uid, gid;
@ -368,9 +368,6 @@ int mkdwarfs(int argc, char** argv) {
("num-workers,N", ("num-workers,N",
po::value<size_t>(&num_workers)->default_value(num_cpu), po::value<size_t>(&num_workers)->default_value(num_cpu),
"number of writer worker threads") "number of writer worker threads")
("max-scanner-workers,M",
po::value<size_t>(&max_scanner_workers)->default_value(num_cpu),
"max number of scanner worker threads")
("max-lookback-blocks,B", ("max-lookback-blocks,B",
po::value<size_t>(&cfg.max_active_blocks)->default_value(1), po::value<size_t>(&cfg.max_active_blocks)->default_value(1),
"how many blocks to scan for segments") "how many blocks to scan for segments")
@ -639,7 +636,7 @@ int mkdwarfs(int argc, char** argv) {
size_t mem_limit = parse_size_with_unit(memory_limit); size_t mem_limit = parse_size_with_unit(memory_limit);
worker_group wg_compress("compress", num_workers); worker_group wg_compress("compress", num_workers);
worker_group wg_scanner("scanner", max_scanner_workers); worker_group wg_scanner("scanner", num_workers);
if (no_progress) { if (no_progress) {
progress_mode = "none"; progress_mode = "none";