From ec8cd8226853f064c9b6e4c109131c50154d725f Mon Sep 17 00:00:00 2001
From: Marcus Holland-Moritz <github@mhxnet.de>
Date: Sun, 16 Mar 2025 18:39:22 +0100
Subject: [PATCH] refactor: no need to move trivial types

---
 src/compression/zstd.cpp                    | 2 +-
 src/writer/internal/similarity_ordering.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/compression/zstd.cpp b/src/compression/zstd.cpp
index a2c9a0bf..3605d4ec 100644
--- a/src/compression/zstd.cpp
+++ b/src/compression/zstd.cpp
@@ -60,7 +60,7 @@ class zstd_block_compressor final : public block_compressor::impl {
   // NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
   std::vector<uint8_t> compress(std::vector<uint8_t>&& data,
                                 std::string const* metadata) const override {
-    return compress(data, std::move(metadata));
+    return compress(data, metadata);
   }
 
   compression_type type() const override { return compression_type::ZSTD; }
diff --git a/src/writer/internal/similarity_ordering.cpp b/src/writer/internal/similarity_ordering.cpp
index 9c3cd492..0603f4f7 100644
--- a/src/writer/internal/similarity_ordering.cpp
+++ b/src/writer/internal/similarity_ordering.cpp
@@ -354,7 +354,7 @@ auto similarity_ordering_<LoggerPolicy>::find_duplicates(
         if (ev.bits_equal(*dst, *src)) {
           dm[*dst].push_back(*src);
         } else if (++dst != src) {
-          *dst = std::move(*src);
+          *dst = *src;
         }
       }