From f760286dabb10e1e898c808d46c83eec4d3abbf8 Mon Sep 17 00:00:00 2001 From: Marcus Holland-Moritz Date: Sat, 6 Nov 2021 14:18:34 +0100 Subject: [PATCH] Suppress two flawfinder false positives --- src/dwarfs/filesystem_extractor.cpp | 2 ++ src/dwarfs/metadata_v2.cpp | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/dwarfs/filesystem_extractor.cpp b/src/dwarfs/filesystem_extractor.cpp index 97df4a2a..342f7a98 100644 --- a/src/dwarfs/filesystem_extractor.cpp +++ b/src/dwarfs/filesystem_extractor.cpp @@ -164,6 +164,8 @@ class filesystem_extractor_ final : public filesystem_extractor::impl { std::array buf; for (;;) { + // This is fine, we're simply reusing the buffer. + // Flawfinder: ignore auto rv = ::read(fd, buf.data(), buf.size()); if (rv <= 0) { diff --git a/src/dwarfs/metadata_v2.cpp b/src/dwarfs/metadata_v2.cpp index 1daf7566..030287c1 100644 --- a/src/dwarfs/metadata_v2.cpp +++ b/src/dwarfs/metadata_v2.cpp @@ -1178,7 +1178,7 @@ metadata_::find(const char* path) const { while (*path) { const char* next = ::strchr(path, '/'); - size_t clen = next ? next - path : ::strlen(path); + size_t clen = next ? next - path : ::strlen(path); // Flawfinder: ignore iv = find(make_directory_view(*iv), std::string_view(path, clen));