TheCloud/dwarfs
1
0
Fork 0
mirror of https://github.com/mhx/dwarfs.git synced 2025-08-04 02:06:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: add more clang-tidy exceptions

Browse Source
This commit is contained in:
Marcus Holland-Moritz 2025-03-16 11:42:34 +01:00
parent 807dbb9aef
commit fdcc93501b
7 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmake/config.h.in
View File

@ -1,5 +1,6 @@
#pragma once #pragma once
// NOLINTBEGIN(cppcoreguidelines-macro-to-enum)
#cmakedefine DWARFS_HAVE_LIBMAGIC 1 #cmakedefine DWARFS_HAVE_LIBMAGIC 1
#cmakedefine DWARFS_HAVE_LIBLZ4 1 #cmakedefine DWARFS_HAVE_LIBLZ4 1
#cmakedefine DWARFS_HAVE_LIBLZMA 1 #cmakedefine DWARFS_HAVE_LIBLZMA 1
@ -11,3 +12,4 @@
#cmakedefine DWARFS_BUILTIN_MANPAGE 1 #cmakedefine DWARFS_BUILTIN_MANPAGE 1
#cmakedefine DWARFS_PERFMON_ENABLED 1 #cmakedefine DWARFS_PERFMON_ENABLED 1
#cmakedefine DWARFS_STACKTRACE_ENABLED 1 #cmakedefine DWARFS_STACKTRACE_ENABLED 1
// NOLINTEND(cppcoreguidelines-macro-to-enum)

1
include/dwarfs/mmif.h
View File

@ -50,6 +50,7 @@ class mmif : public boost::noncopyable {
T const* as(U offset = 0) const { T const* as(U offset = 0) const {
// NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic)
auto raw = static_cast<std::byte const*>(this->addr()) + offset; auto raw = static_cast<std::byte const*>(this->addr()) + offset;
// NOLINTNEXTLINE(bugprone-casting-through-void)
return static_cast<T const*>(static_cast<void const*>(raw)); return static_cast<T const*>(static_cast<void const*>(raw));
} }

2
include/dwarfs/writer/internal/progress.h
View File

@ -148,9 +148,11 @@ class progress {
std::chrono::steady_clock::time_point const start_; std::chrono::steady_clock::time_point const start_;
}; };
// NOLINTBEGIN(cppcoreguidelines-non-private-member-variables-in-classes)
scan_progress similarity; scan_progress similarity;
scan_progress categorize; scan_progress categorize;
scan_progress hash; scan_progress hash;
// NOLINTEND(cppcoreguidelines-non-private-member-variables-in-classes)
private: private:
void add_context(std::shared_ptr<context> const& ctx) const; void add_context(std::shared_ptr<context> const& ctx) const;

2
include/dwarfs/writer/internal/scanner_progress.h
View File

@ -40,7 +40,9 @@ class scanner_progress : public progress::context {
status get_status() const override; status get_status() const override;
// NOLINTBEGIN(cppcoreguidelines-non-private-member-variables-in-classes)
std::atomic<size_t> bytes_processed{0}; std::atomic<size_t> bytes_processed{0};
// NOLINTEND(cppcoreguidelines-non-private-member-variables-in-classes)
private: private:
termcolor const color_; termcolor const color_;

4
src/compression/flac.cpp
View File

@ -58,6 +58,7 @@ class dwarfs_flac_stream_encoder final : public FLAC::Encoder::Stream {
: data_{data} : data_{data}
, pos_{data_.size()} {} , pos_{data_.size()} {}
// NOLINTBEGIN(cppcoreguidelines-avoid-c-arrays)
::FLAC__StreamEncoderReadStatus ::FLAC__StreamEncoderReadStatus
read_callback(FLAC__byte buffer[], size_t* bytes) override { read_callback(FLAC__byte buffer[], size_t* bytes) override {
::memcpy(buffer, data_.data() + pos_, *bytes); ::memcpy(buffer, data_.data() + pos_, *bytes);
@ -75,6 +76,7 @@ class dwarfs_flac_stream_encoder final : public FLAC::Encoder::Stream {
pos_ += bytes; pos_ += bytes;
return FLAC__STREAM_ENCODER_WRITE_STATUS_OK; return FLAC__STREAM_ENCODER_WRITE_STATUS_OK;
} }
// NOLINTEND(cppcoreguidelines-avoid-c-arrays)
::FLAC__StreamEncoderSeekStatus ::FLAC__StreamEncoderSeekStatus
seek_callback(FLAC__uint64 absolute_byte_offset) override { seek_callback(FLAC__uint64 absolute_byte_offset) override {
@ -113,6 +115,7 @@ class dwarfs_flac_stream_decoder final : public FLAC::Decoder::Stream {
: pcm_sample_padding::Msb, : pcm_sample_padding::Msb,
bytes_per_sample_, header_.bits_per_sample().value()} {} bytes_per_sample_, header_.bits_per_sample().value()} {}
// NOLINTBEGIN(cppcoreguidelines-avoid-c-arrays)
::FLAC__StreamDecoderReadStatus ::FLAC__StreamDecoderReadStatus
read_callback(FLAC__byte buffer[], size_t* bytes) override { read_callback(FLAC__byte buffer[], size_t* bytes) override {
if (pos_ >= data_.size()) { if (pos_ >= data_.size()) {
@ -153,6 +156,7 @@ class dwarfs_flac_stream_decoder final : public FLAC::Decoder::Stream {
return FLAC__STREAM_DECODER_WRITE_STATUS_CONTINUE; return FLAC__STREAM_DECODER_WRITE_STATUS_CONTINUE;
} }
// NOLINTEND(cppcoreguidelines-avoid-c-arrays)
void error_callback(::FLAC__StreamDecoderErrorStatus status) override { void error_callback(::FLAC__StreamDecoderErrorStatus status) override {
DWARFS_THROW(runtime_error, DWARFS_THROW(runtime_error,

1
src/terminal_ansi.cpp
View File

@ -90,6 +90,7 @@ bool is_fancy_impl() { return true; }
size_t width_impl() { size_t width_impl() {
struct ::winsize w; struct ::winsize w;
// NOLINTNEXTLINE(cppcoreguidelines-pro-type-vararg)
auto rv = ::ioctl(STDERR_FILENO, TIOCGWINSZ, &w); auto rv = ::ioctl(STDERR_FILENO, TIOCGWINSZ, &w);
return rv == 0 ? w.ws_col : default_width; return rv == 0 ? w.ws_col : default_width;
} }

2
src/writer/segmenter.cpp
View File

@ -657,8 +657,10 @@ class segmenter_progress : public progress::context {
return st; return st;
} }
// NOLINTBEGIN(cppcoreguidelines-non-private-member-variables-in-classes)
std::atomic<file const*> current_file{nullptr}; std::atomic<file const*> current_file{nullptr};
std::atomic<size_t> bytes_processed{0}; std::atomic<size_t> bytes_processed{0};
// NOLINTEND(cppcoreguidelines-non-private-member-variables-in-classes)
private: private:
std::string const context_; std::string const context_;