TheCloud/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-09-10 05:15:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix point binding

Browse Source
This commit is contained in:
Mark Tolmacs 2025-07-28 13:39:58 +02:00
parent 58bd87fc40
commit 4eb62e40dd
No known key found for this signature in database
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
packages/element/src/binding.ts
View File

@ -92,7 +92,7 @@ export type BindingStrategy =
| { | {
mode: BindMode; mode: BindMode;
element: NonDeleted<ExcalidrawBindableElement>; element: NonDeleted<ExcalidrawBindableElement>;
focusPoint?: GlobalPoint; focusPoint: GlobalPoint;
} }
// Break the binding // Break the binding
| { | {
@ -320,7 +320,11 @@ const bindingStrategyForEndpointDragging = (
// where the pointer is and keep the other end intact // where the pointer is and keep the other end intact
if (globalBindMode === "inside") { if (globalBindMode === "inside") {
current = hovered current = hovered
? { element: hovered, mode: hit ? "inside" : "outside" } ? {
element: hovered,
focusPoint: point,
mode: hit ? "inside" : "outside",
}
: { mode: undefined }; : { mode: undefined };
return { current, other }; return { current, other };
@ -348,7 +352,7 @@ const bindingStrategyForEndpointDragging = (
mode: "inside", mode: "inside",
focusPoint: focusPoint:
opts.appState.selectedLinearElement.pointerDownState opts.appState.selectedLinearElement.pointerDownState
.arrowOriginalStartPoint, .arrowOriginalStartPoint ?? point,
}; };
} }
} }
@ -377,7 +381,7 @@ const bindingStrategyForEndpointDragging = (
hovered.x + hovered.width / 2, hovered.x + hovered.width / 2,
hovered.y + hovered.height / 2, hovered.y + hovered.height / 2,
) )
: undefined, : point,
}; };
return { current, other }; return { current, other };
@ -385,7 +389,7 @@ const bindingStrategyForEndpointDragging = (
} }
// No opposite binding or the opposite binding is on a different element // No opposite binding or the opposite binding is on a different element
current = { element: hovered, mode: "orbit" }; current = { element: hovered, mode: "orbit", focusPoint: point };
} }
// The dragged point is inside the hovered bindable element // The dragged point is inside the hovered bindable element
else { else {
@ -395,7 +399,7 @@ const bindingStrategyForEndpointDragging = (
if (oppositeBinding.elementId === hovered.id) { if (oppositeBinding.elementId === hovered.id) {
// The opposite binding is on the binding gap of the same element // The opposite binding is on the binding gap of the same element
if (oppositeBinding.mode !== "inside") { if (oppositeBinding.mode !== "inside") {
current = { element: hovered, mode: "orbit" }; current = { element: hovered, mode: "orbit", focusPoint: point };
other = { mode: null }; other = { mode: null };
return { current, other }; return { current, other };
@ -419,7 +423,7 @@ const bindingStrategyForEndpointDragging = (
hovered.x + hovered.width / 2, hovered.x + hovered.width / 2,
hovered.y + hovered.height / 2, hovered.y + hovered.height / 2,
) )
: undefined, : point,
}; };
return { current, other }; return { current, other };
@ -430,6 +434,7 @@ const bindingStrategyForEndpointDragging = (
current = { current = {
element: hovered, element: hovered,
mode: "orbit", mode: "orbit",
focusPoint: point,
}; };
} }
} }