TheCloud/fuse-overlayfs
1
0
Fork 0
mirror of https://github.com/containers/fuse-overlayfs.git synced 2025-09-11 16:27:14 -04:00
Code Issues Packages Projects Releases Wiki Activity

main, symlink: avoid a chown if it is not needed

Browse Source 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
This commit is contained in:
Giuseppe Scrivano 2019-07-24 16:10:14 +02:00
parent a77edee351
commit 3286532636
No known key found for this signature in database
GPG Key ID: E4730F97F60286ED
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
main.c
View File

@ -3420,6 +3420,8 @@ ovl_symlink (fuse_req_t req, const char *link, fuse_ino_t parent, const char *na
const struct fuse_ctx *ctx = fuse_req_ctx (req); const struct fuse_ctx *ctx = fuse_req_ctx (req);
char wd_tmp_file_name[32]; char wd_tmp_file_name[32];
bool need_delete_whiteout = true; bool need_delete_whiteout = true;
uid_t uid;
gid_t gid;
if (UNLIKELY (ovl_debug (req))) if (UNLIKELY (ovl_debug (req)))
fprintf (stderr, "ovl_symlink(link=%s, ino=%" PRIu64 "s, name=%s)\n", link, parent, name); fprintf (stderr, "ovl_symlink(link=%s, ino=%" PRIu64 "s, name=%s)\n", link, parent, name);
@ -3458,11 +3460,16 @@ ovl_symlink (fuse_req_t req, const char *link, fuse_ino_t parent, const char *na
return; return;
} }
if (fchownat (lo->workdir_fd, wd_tmp_file_name, get_uid (lo, ctx->uid), get_gid (lo, ctx->gid), AT_SYMLINK_NOFOLLOW) < 0) uid = get_uid (lo, ctx->uid);
gid = get_uid (lo, ctx->gid);
if (uid != lo->uid || gid != lo->gid)
{ {
unlinkat (lo->workdir_fd, wd_tmp_file_name, 0); if (fchownat (lo->workdir_fd, wd_tmp_file_name, get_uid (lo, ctx->uid), get_gid (lo, ctx->gid), AT_SYMLINK_NOFOLLOW) < 0)
fuse_reply_err (req, errno); {
return; unlinkat (lo->workdir_fd, wd_tmp_file_name, 0);
fuse_reply_err (req, errno);
return;
}
} }
if (need_delete_whiteout && delete_whiteout (lo, -1, pnode, name) < 0) if (need_delete_whiteout && delete_whiteout (lo, -1, pnode, name) < 0)