TheCloud/fuse-overlayfs
1
0
Fork 0
mirror of https://github.com/containers/fuse-overlayfs.git synced 2025-09-13 09:17:42 -04:00
Code Issues Packages Projects Releases Wiki Activity

main: avoid a stat when doing a chown()

Browse Source 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
This commit is contained in:
Giuseppe Scrivano 2019-07-13 23:18:20 +02:00
parent 5239adf755
commit c2aab54c83
No known key found for this signature in database
GPG Key ID: E4730F97F60286ED
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
main.c
View File

@ -2787,7 +2787,6 @@ ovl_setattr (fuse_req_t req, fuse_ino_t ino, struct stat *attr, int to_set, stru
struct ovl_data *lo = ovl_data (req); struct ovl_data *lo = ovl_data (req);
struct ovl_node *node; struct ovl_node *node;
struct fuse_entry_param e; struct fuse_entry_param e;
struct stat old_st;
struct timespec times[2]; struct timespec times[2];
uid_t uid; uid_t uid;
gid_t gid; gid_t gid;
@ -2812,12 +2811,6 @@ ovl_setattr (fuse_req_t req, fuse_ino_t ino, struct stat *attr, int to_set, stru
dirfd = node_dirfd (node); dirfd = node_dirfd (node);
if (TEMP_FAILURE_RETRY (fstatat (dirfd, node->path, &old_st, AT_SYMLINK_NOFOLLOW)) < 0)
{
fuse_reply_err (req, errno);
return;
}
if (to_set & FUSE_SET_ATTR_CTIME) if (to_set & FUSE_SET_ATTR_CTIME)
{ {
fuse_reply_err (req, EPERM); fuse_reply_err (req, EPERM);
@ -2880,14 +2873,14 @@ ovl_setattr (fuse_req_t req, fuse_ino_t ino, struct stat *attr, int to_set, stru
} }
} }
uid = old_st.st_uid; uid = -1;
gid = old_st.st_gid; gid = -1;
if (to_set & FUSE_SET_ATTR_UID) if (to_set & FUSE_SET_ATTR_UID)
uid = get_uid (lo, attr->st_uid); uid = get_uid (lo, attr->st_uid);
if (to_set & FUSE_SET_ATTR_GID) if (to_set & FUSE_SET_ATTR_GID)
gid = get_gid (lo, attr->st_gid); gid = get_gid (lo, attr->st_gid);
if (uid != old_st.st_uid || gid != old_st.st_gid) if (uid != -1 || gid != -1)
{ {
if (fchownat (dirfd, node->path, uid, gid, AT_SYMLINK_NOFOLLOW) < 0) if (fchownat (dirfd, node->path, uid, gid, AT_SYMLINK_NOFOLLOW) < 0)
{ {