TheCloud/fuse-overlayfs
1
0
Fork 0
mirror of https://github.com/containers/fuse-overlayfs.git synced 2025-08-05 10:55:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

main, rename: fix leak on error

Browse Source 
fix a fd leak on the error exit path.

Closes: https://github.com/containers/fuse-overlayfs/issues/289

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
This commit is contained in:
Giuseppe Scrivano 2021-04-16 20:36:18 +02:00
parent af5cb1c04c
commit d4188a4f59
No known key found for this signature in database
GPG Key ID: E4730F97F60286ED
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
main.c
View File

@ -4404,8 +4404,8 @@ ovl_rename_direct (fuse_req_t req, fuse_ino_t parent, const char *name,
struct ovl_data *lo = ovl_data (req); struct ovl_data *lo = ovl_data (req);
int ret; int ret;
int saved_errno; int saved_errno;
int srcfd = -1; cleanup_close int srcfd = -1;
int destfd = -1; cleanup_close int destfd = -1;
struct ovl_node key; struct ovl_node key;
bool destnode_is_whiteout = false; bool destnode_is_whiteout = false;
@ -4590,20 +4590,12 @@ ovl_rename_direct (fuse_req_t req, fuse_ino_t parent, const char *name,
node->loaded = 0; node->loaded = 0;
ret = 0; ret = 0;
goto cleanup; fuse_reply_err (req, 0);
return;
error: error:
ret = -1; ret = -1;
fuse_reply_err (req, errno);
cleanup:
saved_errno = errno;
if (srcfd >= 0)
close (srcfd);
if (destfd >= 0)
close (destfd);
errno = saved_errno;
fuse_reply_err (req, ret == 0 ? 0 : errno);
} }
static void static void