TheCloud/isle-portable
1
0
Fork 0
mirror of https://github.com/isledecomp/isle-portable.git synced 2025-09-23 20:13:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix wrong delete in MxPtrList<LegoROI*> (#111)

Browse Source 
* Use delete[] for array types in `MxPtrList::Destroy`

* Use template specialization solution
This commit is contained in:
Christian Semmler 2025-05-18 12:50:20 -07:00 committed by GitHub
parent 77cb46f91d
commit d5b5148cd5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
LEGO1/lego/legoomni/include/legoroimaplist.h
View File

@ -15,6 +15,23 @@ class LegoROI;
// VTABLE: LEGO1 0x100d9248 // VTABLE: LEGO1 0x100d9248
// class MxPtrList<LegoROI *> // class MxPtrList<LegoROI *>
// Specialize MxPtrList for LegoROI* in order to fix Destroy.
// TODO: Change to using constexpr in MxPtrList<T>::Destroy once C++17 standard works.
template <>
class MxPtrList<LegoROI*> : public MxList<LegoROI**> {
public:
MxPtrList(MxBool p_ownership) { SetOwnership(p_ownership); }
static void Destroy(LegoROI** p_obj) { delete[] p_obj; }
void SetOwnership(MxBool p_ownership)
{
MxCollection<LegoROI**>::SetDestroy(
p_ownership ? MxPtrList<LegoROI*>::Destroy : MxCollection<LegoROI**>::Destroy
);
}
};
// VTABLE: LEGO1 0x100d9260 // VTABLE: LEGO1 0x100d9260
// SIZE 0x18 // SIZE 0x18
class LegoROIMapList : public MxPtrList<LegoROI*> { class LegoROIMapList : public MxPtrList<LegoROI*> {