Mark Zeren e39fb0083c Normalize comment EOLs while reading instead of while writing ...

Tests are currently failing when git cloning on Windows with autocrlf = true. In
that setup multiline comments contain \r\n EOLs. The test code assumes that
comments contain \n EOLs and opens the .actual files (etc.) with "wt" which
converts \n to \r\n. Thus we end up with \r\r\n EOLs in the output, which
triggers a test failure.

Instead we should cannonicalize comments while reading so that they contain only
\n EOLs. This approach simplifies other parts of the reader and writer logic,
and requires no changes to the test. It is a breaking change, but probably the
Right Thing going forward.

This change also fixes dereferencing past the end of the comment string in
StyledWriter::writeCommentBeforeValue.

Tests should be added with appropriate .gitattributes for the input files to
ensure that we run tests for DOS, Mac, and Unix EOL files on all platforms. For
now this change is enough to unblock Windows builds.

issue #116

2015-01-20 13:45:44 -06:00

..

jsontestrunner

Added printing of comments to *.actual test files

2014-10-09 16:33:29 -04:00

lib_json

Normalize comment EOLs while reading instead of while writing

2015-01-20 13:45:44 -06:00

test_lib_json

fix double->string->double round-trip (bump minor ver.)

2015-01-06 12:40:36 -06:00

CMakeLists.txt

- New CMake based build system. Based in part on contribution from

2013-05-08 20:21:11 +00:00