From f9bfc752033641f854a06327ebfb1269713d9183 Mon Sep 17 00:00:00 2001 From: xzxzzxzxzca Date: Sat, 9 Dec 2023 22:07:48 +0100 Subject: [PATCH] Do not touch CMAKE_MODULE_PATH Now that the library does not provide any CMake find-modules, it is useless to alter the global. Besides, the only way for a higher level integrating project to provide its own dependency resolution mechanism (Conan, local source tree, etc)relies on appending to CMAKE_MODULE_PATH prior to locating packages. Sdl2pp overriding the variable breaks this mechanism and therefore can only locate a globally installed copy of SDL, which is often inconvenient or plain impossible. --- CMakeLists.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5b9ecf5..902c77c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -3,8 +3,6 @@ cmake_minimum_required(VERSION 3.16 FATAL_ERROR) # meta project(libSDL2pp LANGUAGES CXX VERSION 0.18.1) -set(CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/cmake) - set(CMAKE_CXX_STANDARD 17) set(CMAKE_CXX_STANDARD_REQUIRED YES) set(CMAKE_CXX_EXTENSIONS NO)