From 70c43bd436cc5b6da36f478f7bdb5b166a3d0fc8 Mon Sep 17 00:00:00 2001 From: Tobias Frost Date: Wed, 10 Feb 2021 12:30:46 +0100 Subject: [PATCH] Fix a signed/unsigned comparision issue. ssize_t needs to be used, otherwise the comparasion _buff_size < 0 can never be true. and as archive_read_data returns ssize_t a error could not be detected. --- archive_reader_entry_buffer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/archive_reader_entry_buffer.cpp b/archive_reader_entry_buffer.cpp index b7f0253..3a8dad4 100644 --- a/archive_reader_entry_buffer.cpp +++ b/archive_reader_entry_buffer.cpp @@ -43,7 +43,7 @@ int entry_buffer::underflow() { if(gptr() == egptr()) { - size_t _buff_size = archive_read_data(_archive, _buff, _buff_max_size); + ssize_t _buff_size = archive_read_data(_archive, _buff, _buff_max_size); if( _buff_size < 0 ) {