TheCloud/matterbridge
1
0
Fork 0
mirror of https://github.com/42wim/matterbridge.git synced 2025-09-21 02:44:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Ignore discord updates when the message hasn't been edited in the last 6 hours

Browse Source 
Discord sends spurious updates for messages that haven't been edited, or
haven't been edited recently. Messages from as far back as 5 years ago have
been observed to be updated, always with a URL or embedded content.

These need to be ignored because it's confusing when out of date messages
are bridged as new messages with no context to protocols that don't support
edits. Edited messages normally arrive as updates immediately.
This commit is contained in:
Simon Arlott 2025-08-18 10:41:43 +01:00
parent c4157a4d5b
commit be96f94b41
No known key found for this signature in database
GPG Key ID: DF001BFD83E75990
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
bridge/discord/handlers.go
View File

@ -1,6 +1,8 @@
package bdiscord
import (
"time"
"github.com/42wim/matterbridge/bridge/config"
"github.com/bwmarrin/discordgo"
"github.com/davecgh/go-spew/spew"
@ -63,6 +65,13 @@ func (b *Bdiscord) messageTyping(s *discordgo.Session, m *discordgo.TypingStart)
b.Remote <- rmsg
}
// Discord sends spurious updates for messages that haven't been edited, or
// haven't been edited recently. Messages from as far back as 5 years ago have
// been observed to be updated, always with a URL or embedded content.
//
// These need to be ignored because it's confusing when out of date messages
// are bridged as new messages with no context to protocols that don't support
// edits. Edited messages normally arrive as updates immediately.
func (b *Bdiscord) messageUpdate(s *discordgo.Session, m *discordgo.MessageUpdate) { //nolint:unparam
if m.GuildID != b.guildID {
b.Log.Debugf("Ignoring messageUpdate because it originates from a different guild")
@ -73,6 +82,12 @@ func (b *Bdiscord) messageUpdate(s *discordgo.Session, m *discordgo.MessageUpdat
}
// only when message is actually edited
if m.Message.EditedTimestamp != nil {
// message must have been edited recently
delay := time.Now().Sub(*m.Message.EditedTimestamp)
if delay >= time.Duration(6) * time.Hour {
return
}
b.Log.Debugf("Sending edit message")
m.Content += b.GetString("EditSuffix")
msg := &discordgo.MessageCreate{