cleanup: Removal of unnecessary null checks around delete

Fixes #934
This commit is contained in:
rdb 2020-05-05 10:40:31 +02:00
parent 5030ad6b13
commit 1ff11c1e16
3 changed files with 12 additions and 28 deletions

View File

@ -88,9 +88,9 @@ void MeshDrawer2D::generator(int budget) {
void MeshDrawer2D::begin() {
// recreate our rewriters
if (_vertex != nullptr) delete _vertex;
if (_uv != nullptr) delete _uv;
if (_color != nullptr) delete _color;
delete _vertex;
delete _uv;
delete _color;
_vertex = new GeomVertexRewriter(_vdata, "vertex");
_uv = new GeomVertexRewriter(_vdata, "texcoord");

View File

@ -58,9 +58,7 @@ Time_Accumulator() :
*/
inline Time_Accumulator::
~Time_Accumulator() {
if (_accum_start != nullptr) {
delete _accum_start;
}
}
/**

View File

@ -199,39 +199,25 @@ void LwoToEggConverter::
cleanup() {
_lwo_header.clear();
if (_generic_layer != nullptr) {
delete _generic_layer;
_generic_layer = nullptr;
}
Layers::iterator li;
for (li = _layers.begin(); li != _layers.end(); ++li) {
CLwoLayer *layer = (*li);
if (layer != nullptr) {
for (CLwoLayer *layer : _layers) {
delete layer;
}
}
_layers.clear();
Clips::iterator ci;
for (ci = _clips.begin(); ci != _clips.end(); ++ci) {
CLwoClip *clip = (*ci);
if (clip != nullptr) {
for (CLwoClip *clip : _clips) {
delete clip;
}
}
_clips.clear();
Points::iterator pi;
for (pi = _points.begin(); pi != _points.end(); ++pi) {
CLwoPoints *points = (*pi);
for (CLwoPoints *points : _points) {
delete points;
}
_points.clear();
Polygons::iterator gi;
for (gi = _polygons.begin(); gi != _polygons.end(); ++gi) {
CLwoPolygons *polygons = (*gi);
for (CLwoPolygons *polygons : _polygons) {
delete polygons;
}
_polygons.clear();