TheCloud/panda3d
1
0
Fork 0
mirror of https://github.com/panda3d/panda3d.git synced 2025-09-28 15:53:55 -04:00
Code Issues Packages Projects Releases Wiki Activity

rplight: Fix redundant get_lens() calls

Browse Source
This commit is contained in:
rdb 2022-11-26 16:52:37 +01:00
parent 1f9f6a618f
commit 37795cd596
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
contrib/src/rplight/pssmCameraRig.cxx
View File

@ -296,9 +296,10 @@ void PSSMCameraRig::compute_pssm_splits(const LMatrix4& transform, float max_dis
// Reset the film size, offset and far-plane // Reset the film size, offset and far-plane
Camera* cam = DCAST(Camera, _cam_nodes[i].node()); Camera* cam = DCAST(Camera, _cam_nodes[i].node());
cam->get_lens()->set_film_size(1, 1); Lens *lens = cam->get_lens();
cam->get_lens()->set_film_offset(0, 0); lens->set_film_size(1, 1);
cam->get_lens()->set_near_far(1, 100); lens->set_film_offset(0, 0);
lens->set_near_far(1, 100);
// Find a good initial position // Find a good initial position
_cam_nodes[i].set_pos(cam_start); _cam_nodes[i].set_pos(cam_start);
@ -320,16 +321,16 @@ void PSSMCameraRig::compute_pssm_splits(const LMatrix4& transform, float max_dis
if (_max_film_sizes[i].get_x() < film_size.get_x()) _max_film_sizes[i].set_x(film_size.get_x()); if (_max_film_sizes[i].get_x() < film_size.get_x()) _max_film_sizes[i].set_x(film_size.get_x());
if (_max_film_sizes[i].get_y() < film_size.get_y()) _max_film_sizes[i].set_y(film_size.get_y()); if (_max_film_sizes[i].get_y() < film_size.get_y()) _max_film_sizes[i].set_y(film_size.get_y());
cam->get_lens()->set_film_size(_max_film_sizes[i] * filmsize_bias); lens->set_film_size(_max_film_sizes[i] * filmsize_bias);
} else { } else {
// If we don't use a fixed film size, we can just set the film size // If we don't use a fixed film size, we can just set the film size
// on the lens. // on the lens.
cam->get_lens()->set_film_size(film_size * filmsize_bias); lens->set_film_size(film_size * filmsize_bias);
} }
// Compute new film offset // Compute new film offset
cam->get_lens()->set_film_offset(film_offset); lens->set_film_offset(film_offset);
cam->get_lens()->set_near_far(10, best_max_extent.get_z()); lens->set_near_far(10, best_max_extent.get_z());
_camera_nearfar[i] = LVecBase2(10, best_max_extent.get_z()); _camera_nearfar[i] = LVecBase2(10, best_max_extent.get_z());
// Compute the camera MVP // Compute the camera MVP