From 37c48ea8290a2d07a69cc2a938263e1dfb849017 Mon Sep 17 00:00:00 2001 From: rdb Date: Fri, 4 Mar 2022 11:27:19 +0100 Subject: [PATCH] dist: Helpful error for invalid android_abis value --- direct/src/dist/commands.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/direct/src/dist/commands.py b/direct/src/dist/commands.py index 5af82606a3..3083fd33a1 100644 --- a/direct/src/dist/commands.py +++ b/direct/src/dist/commands.py @@ -465,6 +465,12 @@ class build_apps(setuptools.Command): elif not self.android_abis: self.android_abis = ['arm64-v8a', 'armeabi-v7a', 'x86_64', 'x86'] + supported_abis = 'armeabi', 'armeabi-v7a', 'arm64-v8a', 'x86', 'x86-64', 'mips', 'mips64' + unsupported_abis = set(self.android_abis) - set(supported_abis) + if unsupported_abis: + raise ValueError(f'Unrecognized value(s) for android_abis: {", ".join(unsupported_abis)}\n' + f'Valid ABIs are: {", ".join(supported_abis)}') + self.icon_objects = {} for app, iconpaths in self.icons.items(): if not isinstance(iconpaths, list) and not isinstance(iconpaths, tuple):