TheCloud/panda3d
1
0
Fork 0
mirror of https://github.com/panda3d/panda3d.git synced 2025-09-29 00:06:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

tform: do not stop mouse button capture until all buttons are released

Browse Source 
We may want to consider a more elegant solution for capturing in the future.  In the meantime, this fixes #843.
This commit is contained in:
rdb 2020-03-18 18:29:42 +01:00
parent eeeea274a4
commit 43fa7efaaa
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
panda/src/tform/mouseWatcher.cxx
View File

@ -990,9 +990,6 @@ release(ButtonHandle button) {
// Button up. Send the up event associated with the region(s) we were
// over when the button went down.
// There is some danger of losing button-up events here. If more than one
// button goes down together, we won't detect both of the button-up events
// properly.
if (_preferred_button_down_region != nullptr) {
param.set_outside(_preferred_button_down_region != _preferred_region);
_preferred_button_down_region->release(param);
@ -1000,8 +997,22 @@ release(ButtonHandle button) {
_preferred_button_down_region, button);
}
_button_down = false;
_preferred_button_down_region = nullptr;
// Do not stop capturing until the last mouse button has gone up. This is
// needed to prevent stopping the capture until the capturing region has
// finished processing all the releases.
bool has_button = false;
for (size_t i = 0; i < MouseButton::num_mouse_buttons; ++i) {
if (MouseButton::_buttons[i] != button &&
_current_buttons_down.get_bit(MouseButton::_buttons[i].get_index())) {
has_button = true;
}
}
if (!has_button) {
// The last mouse button went up.
_button_down = false;
_preferred_button_down_region = nullptr;
}
} else {
// It's a keyboard button; therefore, send the event to every region that