TheCloud/panda3d
1
0
Fork 0
mirror of https://github.com/panda3d/panda3d.git synced 2025-10-03 10:22:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

ffmpeg: Simplify ffmpegAudioCursor.cxx a little

Browse Source 
This refactors the `reload_buffer` loop so all of the decode
logic is inside the loop, and all of the resampling logic is
outside.
This commit is contained in:
Sam Edwards 2018-03-31 02:54:48 -06:00
parent eb591674e0
commit 4ffd364415
1 changed files with 54 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
panda/src/ffmpeg/ffmpegAudioCursor.cxx
View File

@ -297,17 +297,17 @@ fetch_packet() {
*/ */
bool FfmpegAudioCursor:: bool FfmpegAudioCursor::
reload_buffer() { reload_buffer() {
int got_frame = 0;
while (_buffer_head == _buffer_tail) { while (!got_frame) {
// If we're out of packets, generate silence. // If we're out of packets, generate silence.
if (_packet->data == 0) { if (_packet->data == nullptr) {
_buffer_head = 0; _buffer_head = 0;
_buffer_tail = _buffer_size; _buffer_tail = _buffer_size;
memset(_buffer, 0, _buffer_size * 2); memset(_buffer, 0, _buffer_size * 2);
return true; return true;
} else if (_packet_size > 0) { } else if (_packet_size == 0) {
int bufsize = _buffer_size * 2; fetch_packet();
int got_frame; }
AVPacket *pkt; AVPacket *pkt;
#if LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(57, 12, 100) #if LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(57, 12, 100)
@ -329,8 +329,16 @@ reload_buffer() {
av_free_packet(pkt); av_free_packet(pkt);
#endif #endif
bufsize = 0; if (len < 0) {
if (got_frame) { return false;
} else if (len == 0) {
return true;
}
_packet_data += len;
_packet_size -= len;
}
int bufsize;
#ifdef HAVE_SWRESAMPLE #ifdef HAVE_SWRESAMPLE
if (_resample_ctx) { if (_resample_ctx) {
// Resample the data to signed 16-bit sample format. // Resample the data to signed 16-bit sample format.
@ -342,27 +350,15 @@ reload_buffer() {
bufsize = _frame->linesize[0]; bufsize = _frame->linesize[0];
memcpy(_buffer, _frame->data[0], bufsize); memcpy(_buffer, _frame->data[0], bufsize);
} }
}
#if LIBAVUTIL_VERSION_INT > AV_VERSION_INT(52, 19, 100) #if LIBAVUTIL_VERSION_INT > AV_VERSION_INT(52, 19, 100)
av_frame_unref(_frame); av_frame_unref(_frame);
#endif #endif
if (len < 0) {
return false;
} else if (len == 0){
return true;
}
_packet_data += len;
_packet_size -= len;
if (bufsize > 0) { if (bufsize > 0) {
_buffer_head = 0; _buffer_head = 0;
_buffer_tail = (bufsize/2); _buffer_tail = (bufsize/2);
return true; return true;
} }
} else {
fetch_packet();
}
}
return true; return true;
} }