diff --git a/panda/src/glxdisplay/glxGraphicsPipe.cxx b/panda/src/glxdisplay/glxGraphicsPipe.cxx index eb470445cf..40a4686e6c 100644 --- a/panda/src/glxdisplay/glxGraphicsPipe.cxx +++ b/panda/src/glxdisplay/glxGraphicsPipe.cxx @@ -280,7 +280,7 @@ make_output(const string &name, GraphicsStateGuardian *gsg, GraphicsOutput *host, int retry, - bool precertify) { + bool &precertify) { if (!_is_valid) { return NULL; diff --git a/panda/src/glxdisplay/glxGraphicsPipe.h b/panda/src/glxdisplay/glxGraphicsPipe.h index 1b9fd09d64..2be1b9d335 100644 --- a/panda/src/glxdisplay/glxGraphicsPipe.h +++ b/panda/src/glxdisplay/glxGraphicsPipe.h @@ -119,7 +119,7 @@ protected: GraphicsStateGuardian *gsg, GraphicsOutput *host, int retry, - bool precertify); + bool &precertify); private: #ifdef HAVE_GLXFBCONFIG diff --git a/panda/src/glxdisplay/glxGraphicsStateGuardian.cxx b/panda/src/glxdisplay/glxGraphicsStateGuardian.cxx index 254164b8ec..ef528a02fa 100644 --- a/panda/src/glxdisplay/glxGraphicsStateGuardian.cxx +++ b/panda/src/glxdisplay/glxGraphicsStateGuardian.cxx @@ -120,7 +120,8 @@ reset() { software = true; } - FrameBufferProperties properties = get_properties(); + // FIXME: should these properties be taken from the window? + FrameBufferProperties properties = get_default_properties(); int frame_buffer_mode = properties.get_frame_buffer_mode(); // If "Mesa" is present, assume software. However, if "Mesa DRI" is @@ -150,10 +151,13 @@ reset() { frame_buffer_mode = (frame_buffer_mode | FrameBufferProperties::FM_hardware) & ~FrameBufferProperties::FM_software; } + // FIXME: we need a place to store this now. + /* // Update the GSG's record to indicate whether we believe it is a // hardware or software renderer. properties.set_frame_buffer_mode(frame_buffer_mode); set_properties(properties); + */ } //////////////////////////////////////////////////////////////////// diff --git a/panda/src/glxdisplay/glxGraphicsWindow.cxx b/panda/src/glxdisplay/glxGraphicsWindow.cxx index 3860f65261..0eea2e5497 100644 --- a/panda/src/glxdisplay/glxGraphicsWindow.cxx +++ b/panda/src/glxdisplay/glxGraphicsWindow.cxx @@ -50,7 +50,7 @@ glxGraphicsWindow(GraphicsPipe *pipe, int x_size, int y_size, int flags, GraphicsStateGuardian *gsg, GraphicsOutput *host) : - GraphicsWindow(pipe, name, x_size, y_size, flags, gsg, host) + GraphicsWindow(pipe, name, properties, x_size, y_size, flags, gsg, host) { glxGraphicsPipe *glx_pipe; DCAST_INTO_V(glx_pipe, _pipe); diff --git a/panda/src/mesadisplay/osMesaGraphicsPipe.cxx b/panda/src/mesadisplay/osMesaGraphicsPipe.cxx index b0c4147a4e..2e1936c43d 100644 --- a/panda/src/mesadisplay/osMesaGraphicsPipe.cxx +++ b/panda/src/mesadisplay/osMesaGraphicsPipe.cxx @@ -144,7 +144,7 @@ make_output(const string &name, ((flags&BF_require_window)!=0)|| ((flags&BF_size_track_host)!=0)|| ((flags&BF_can_bind_every)!=0)|| - (properties != gsg->get_default_properties()) { + (properties != gsg->get_default_properties())) { return NULL; } return new OsMesaGraphicsBuffer(this, name, properties, diff --git a/panda/src/mesadisplay/osMesaGraphicsPipe.h b/panda/src/mesadisplay/osMesaGraphicsPipe.h index 08dc056f7c..94fff61b5d 100644 --- a/panda/src/mesadisplay/osMesaGraphicsPipe.h +++ b/panda/src/mesadisplay/osMesaGraphicsPipe.h @@ -47,14 +47,14 @@ public: protected: virtual PT(GraphicsStateGuardian) make_gsg(const FrameBufferProperties &properties, - GraphicsStateGuardian *share_with); + GraphicsStateGuardian *share_with); virtual PT(GraphicsOutput) make_output(const string &name, const FrameBufferProperties &properties, int x_size, int y_size, int flags, GraphicsStateGuardian *gsg, GraphicsOutput *host, int retry, - bool precertify); + bool &precertify); private: