From 6413cc28e301164adce1613d9e1aece2324a522a Mon Sep 17 00:00:00 2001 From: Darren Ranalli Date: Tue, 3 Apr 2007 05:19:54 +0000 Subject: [PATCH] minor optimization in accept --- direct/src/showbase/Messenger.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/direct/src/showbase/Messenger.py b/direct/src/showbase/Messenger.py index 80c40d3045..d04ffb156b 100644 --- a/direct/src/showbase/Messenger.py +++ b/direct/src/showbase/Messenger.py @@ -52,7 +52,8 @@ class Messenger: If the persistent flag is set, it will continue to respond to this event, otherwise it will respond only once. """ - if Messenger.notify.getDebug(): + notifyDebug = Messenger.notify.getDebug() + if notifyDebug: Messenger.notify.debug( "object: %s\n accepting: %s\n method: %s\n extraArgs: %s\n persistent: %s" % (object, event, method, extraArgs, persistent)) @@ -66,7 +67,7 @@ class Messenger: # Make sure we are not inadvertently overwriting an existing event # on this particular object. - if Messenger.notify.getDebug(): + if notifyDebug: if acceptorDict.has_key(object): oldMethod = acceptorDict[object][0] if oldMethod == method: @@ -81,6 +82,7 @@ class Messenger: acceptorDict[object] = [method, extraArgs, persistent] # Remember that this object is listening for this event + # TODO: can we really guarantee that all DirectObjects are valid dict keys? eventDict = self.__objectEvents.setdefault(object, {}) eventDict.setdefault(event, None)