TheCloud/panda3d
1
0
Fork 0
mirror of https://github.com/panda3d/panda3d.git synced 2025-09-30 00:32:57 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix some warnings comparing char against EOF

Browse Source 
This is not possible on platforms where char is unsigned.  In cases where fail() is checked, it is also unnecessary.
This commit is contained in:
rdb 2019-01-20 00:30:34 +01:00
parent ba4036e290
commit 7968022c23
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
panda/src/downloader/documentSpec.cxx
View File

@ -66,7 +66,7 @@ input(std::istream &in) {
// Scan the tag, up to but not including the closing paren. // Scan the tag, up to but not including the closing paren.
std::string tag; std::string tag;
in >> ch; in >> ch;
while (!in.fail() && ch != EOF && ch != ')') { while (!in.fail() && ch != ')') {
tag += ch; tag += ch;
// We want to include embedded whitespace, so we use get(). // We want to include embedded whitespace, so we use get().
ch = in.get(); ch = in.get();
@ -81,7 +81,7 @@ input(std::istream &in) {
// Scan the date, up to but not including the closing bracket. // Scan the date, up to but not including the closing bracket.
if (ch != ']') { if (ch != ']') {
std::string date; std::string date;
while (!in.fail() && ch != EOF && ch != ']') { while (!in.fail() && ch != ']') {
date += ch; date += ch;
ch = in.get(); ch = in.get();
} }

2
panda/src/downloader/httpDate.cxx
View File

@ -279,7 +279,7 @@ input(std::istream &in) {
string date; string date;
ch = in.get(); ch = in.get();
while (!in.fail() && ch != EOF && ch != '"') { while (!in.fail() && ch != '"') {
date += ch; date += ch;
ch = in.get(); ch = in.get();
} }

2
panda/src/pnmimagetypes/pnmFileTypePNM.cxx
View File

@ -193,7 +193,7 @@ pm_getuint(istream * const ifP) {
'unsigned int'), issue an error message to stderr and abort the 'unsigned int'), issue an error message to stderr and abort the
program. program.
-----------------------------------------------------------------------------*/ -----------------------------------------------------------------------------*/
char ch; int ch;
unsigned int i; unsigned int i;
// skip whitespace // skip whitespace