TheCloud/panda3d
1
0
Fork 0
mirror of https://github.com/panda3d/panda3d.git synced 2025-09-29 16:20:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

interrogate: avoid GC exceptions processing objects mid-construction

Browse Source 
After 38692dd525525e20cd06204a646b35dd7e39902a, GC pauses occuring before
the __init__ function of the C++ backed object is called in a inheritance chain will
cause an exception during garbage collection and cause the python runtime to exit.

This can be observed by say, forcing a GC-pause in MetaInterval.__init__ before it calls CMetaInterval::__init__.
This commit is contained in:
John C. Allwein 2024-05-11 22:31:22 -06:00
parent 38692dd525
commit 8cc62c9706
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dtool/src/interrogate/interfaceMakerPythonNative.cxx
View File

@ -3057,9 +3057,10 @@ write_module_class(ostream &out, Object *obj) {
out << "static int Dtool_Traverse_" << ClassName << "(PyObject *self, visitproc visit, void *arg) {\n";
out << " // If the only reference remaining is the one held by the Python wrapper,\n";
out << " // report the circular reference to Python's GC, so that it can break it.\n";
out << " " << cClassName << " *local_this = nullptr;\n";
out << " if (!Dtool_Call_ExtractThisPointer(self, Dtool_" << ClassName << ", (void **)&local_this)) {\n";
out << " return -1;\n";
out << " " << cClassName << " *local_this;\n";
out << " DTOOL_Call_ExtractThisPointerForType(self, &Dtool_" << ClassName << ", (void**)(&local_this));\n";
out << " if (local_this == nullptr) {\n";
out << " return 0;\n";
out << " }\n";
out << " if (local_this->get_ref_count() == (int)((Dtool_PyInstDef *)self)->_memory_rules) {\n";
if (py_subclassable) {