From 9b2e322f291653df8c49b44b5e5fb91590b2faf2 Mon Sep 17 00:00:00 2001 From: rdb Date: Sun, 1 Feb 2015 17:41:55 +0100 Subject: [PATCH] Display better error when encountering invalid prim index --- panda/src/gobj/geomPrimitive.cxx | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/panda/src/gobj/geomPrimitive.cxx b/panda/src/gobj/geomPrimitive.cxx index 32ce676486..8390f6e0f4 100644 --- a/panda/src/gobj/geomPrimitive.cxx +++ b/panda/src/gobj/geomPrimitive.cxx @@ -2445,6 +2445,17 @@ get_num_primitives() const { //////////////////////////////////////////////////////////////////// bool GeomPrimitivePipelineReader:: check_valid(const GeomVertexDataPipelineReader *data_reader) const { - return get_num_vertices() == 0 || - get_max_vertex() < data_reader->get_num_rows(); + if (get_num_vertices() != 0 && + get_max_vertex() >= data_reader->get_num_rows()) { + +#ifndef NDEBUG + gobj_cat.error() + << get_object()->get_type() << " references vertices up to " + << get_max_vertex() << ", but GeomVertexData has only " + << data_reader->get_num_rows() << " rows!\n"; +#endif + return false; + } + + return true; }