TheCloud/panda3d
1
0
Fork 0
mirror of https://github.com/panda3d/panda3d.git synced 2025-10-17 20:23:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

alloca() fails with large buffers

Browse Source
This commit is contained in:
David Rose 2007-05-27 01:37:10 +00:00
parent 51fb06511f
commit bf43d9fb7d
1 changed files with 28 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
panda/src/putil/datagramInputFile.cxx
View File

@ -142,17 +142,37 @@ get_datagram(Datagram &data) {
}
// Now, read the datagram itself.
char *buffer = (char *)alloca(num_bytes);
nassertr(buffer != (char *)NULL, false);
_in->read(buffer, num_bytes);
if (_in->fail() || _in->eof()) {
_error = true;
return false;
// If the number of bytes is large, we will need to allocate a
// temporary buffer from the heap. Otherwise, we can get away with
// allocating it on the stack, via alloca().
if (num_bytes > 65536) {
char *buffer = new char[num_bytes];
nassertr(buffer != (char *)NULL, false);
_in->read(buffer, num_bytes);
if (_in->fail() || _in->eof()) {
_error = true;
delete[] buffer;
return false;
}
data = Datagram(buffer, num_bytes);
delete[] buffer;
} else {
char *buffer = (char *)alloca(num_bytes);
nassertr(buffer != (char *)NULL, false);
_in->read(buffer, num_bytes);
if (_in->fail() || _in->eof()) {
_error = true;
return false;
}
data = Datagram(buffer, num_bytes);
}
data = Datagram(buffer, num_bytes);
return true;
}