diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml deleted file mode 100644 index c612c782f3..0000000000 --- a/.github/workflows/lint.yml +++ /dev/null @@ -1,39 +0,0 @@ -name: Lint -on: [pull_request] - -jobs: - clang-tidy: - runs-on: ubuntu-20.04 - steps: - - uses: actions/checkout@v3 - with: - fetch-depth: 2 - - name: Install clang-tidy - run: | - sudo apt-get update - sudo apt-get install -y clang-tidy build-essential pkg-config libpng-dev libjpeg-dev libtiff-dev zlib1g-dev libssl-dev libx11-dev libgl1-mesa-dev libxrandr-dev libxxf86dga-dev libxcursor-dev libfreetype6-dev libvorbis-dev libeigen3-dev libopenal-dev libode-dev libbullet-dev libgtk-3-dev libassimp-dev libopenexr-dev - - name: Prepare compile_commands.json - run: | - cmake -B build -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_UNITY_BUILD=OFF -DHAVE_PYTHON=OFF -DINTERROGATE_PYTHON_INTERFACE=OFF - - name: Copy prebuilt files - run: | - for fn in **/*.prebuilt; do - echo mkdir -p $(dirname "cmake/$fn"); - echo cp "$fn" "cmake/${fn%.*}"; - done - - name: Create results directory - run: | - mkdir clang-tidy-result - - name: Analyze - run: | - git diff -U0 HEAD^ | clang-tidy-diff -p1 -path build -export-fixes clang-tidy-result/fixes.yml - - name: Save PR metadata - run: | - echo ${{ github.event.number }} > clang-tidy-result/pr-id.txt - echo ${{ github.event.pull_request.head.repo.full_name }} > clang-tidy-result/pr-head-repo.txt - echo ${{ github.event.pull_request.head.ref }} > clang-tidy-result/pr-head-ref.txt - - name: Upload results - uses: actions/upload-artifact@v2 - with: - name: clang-tidy-result - path: clang-tidy-result/ diff --git a/.github/workflows/review.yml b/.github/workflows/review.yml deleted file mode 100644 index 512faa51d6..0000000000 --- a/.github/workflows/review.yml +++ /dev/null @@ -1,77 +0,0 @@ -name: Post PR Review - -on: - workflow_run: - workflows: ["Lint"] - types: [completed] - -jobs: - clang-tidy-results: - # Trigger the job only if the previous (insecure) workflow completed successfully - if: ${{ github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'success' }} - runs-on: ubuntu-20.04 - steps: - - name: Download analysis results - uses: actions/github-script@v3.1.0 - with: - script: | - let artifacts = await github.actions.listWorkflowRunArtifacts({ - owner: context.repo.owner, - repo: context.repo.repo, - run_id: ${{ github.event.workflow_run.id }}, - }); - let matchArtifact = artifacts.data.artifacts.filter((artifact) => { - return artifact.name == "clang-tidy-result" - })[0]; - let download = await github.actions.downloadArtifact({ - owner: context.repo.owner, - repo: context.repo.repo, - artifact_id: matchArtifact.id, - archive_format: "zip", - }); - let fs = require("fs"); - fs.writeFileSync("${{github.workspace}}/clang-tidy-result.zip", Buffer.from(download.data)); - - name: Set environment variables - run: | - mkdir clang-tidy-result - unzip clang-tidy-result.zip -d clang-tidy-result - echo "pr_id=$(cat clang-tidy-result/pr-id.txt)" >> $GITHUB_ENV - echo "pr_head_repo=$(cat clang-tidy-result/pr-head-repo.txt)" >> $GITHUB_ENV - echo "pr_head_ref=$(cat clang-tidy-result/pr-head-ref.txt)" >> $GITHUB_ENV - - uses: actions/checkout@v2 - with: - repository: ${{ env.pr_head_repo }} - ref: ${{ env.pr_head_ref }} - persist-credentials: false - - name: Redownload analysis results - uses: actions/github-script@v3.1.0 - with: - script: | - let artifacts = await github.actions.listWorkflowRunArtifacts({ - owner: context.repo.owner, - repo: context.repo.repo, - run_id: ${{github.event.workflow_run.id}}, - }); - let matchArtifact = artifacts.data.artifacts.filter((artifact) => { - return artifact.name == "clang-tidy-result" - })[0]; - let download = await github.actions.downloadArtifact({ - owner: context.repo.owner, - repo: context.repo.repo, - artifact_id: matchArtifact.id, - archive_format: "zip", - }); - let fs = require("fs"); - fs.writeFileSync("${{github.workspace}}/clang-tidy-result.zip", Buffer.from(download.data)); - - name: Extract analysis results - run: | - mkdir clang-tidy-result - unzip clang-tidy-result.zip -d clang-tidy-result - - name: Run clang-tidy-pr-comments action - uses: platisd/clang-tidy-pr-comments@master - with: - github_token: ${{ github.token }} - clang_tidy_fixes: clang-tidy-result/fixes.yml - pull_request_id: ${{ env.pr_id }} - request_changes: true - suggestions_per_comment: 10