TheCloud/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2025-09-10 07:47:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

breaking,net.ftp: allow to choose a different port than port 21 (change FTP.connect to accept host:port, not just a host address) (#21185)

Browse Source
This commit is contained in:
4zv4l 2024-04-05 16:23:01 +08:00 committed by GitHub
parent 2c646bfadd
commit 38b3115a9c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
vlib/net/ftp/ftp.v
View File

@ -100,9 +100,9 @@ fn (mut zftp FTP) read() !(int, string) {
return code, data return code, data
} }
// connect establishes an FTP connection to the host at `ip` port 21. // connect establishes an FTP connection to the host at `oaddress` (ip:port).
pub fn (mut zftp FTP) connect(ip string) !bool { pub fn (mut zftp FTP) connect(oaddress string) !bool {
zftp.conn = net.dial_tcp('${ip}:21')! zftp.conn = net.dial_tcp(oaddress)!
zftp.reader = io.new_buffered_reader(reader: zftp.conn) zftp.reader = io.new_buffered_reader(reader: zftp.conn)
code, _ := zftp.read()! code, _ := zftp.read()!
if code == ftp.connected { if code == ftp.connected {

2
vlib/net/ftp/ftp_test.v
View File

@ -17,7 +17,7 @@ fn ftp_client_test_inside() ! {
defer { defer {
zftp.close() or { panic(err) } zftp.close() or { panic(err) }
} }
connect_result := zftp.connect('ftp.redhat.com')! connect_result := zftp.connect('ftp.redhat.com:21')!
assert connect_result assert connect_result
login_result := zftp.login('ftp', 'ftp')! login_result := zftp.login('ftp', 'ftp')!
assert login_result assert login_result