TheCloud/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2025-09-25 13:54:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

checker: fix missing check for empty array to generic param (fix #25056) (#25118)

Browse Source
This commit is contained in:
Felipe Pena 2025-08-17 14:44:36 -03:00 committed by GitHub
parent 51630f1795
commit 4a4434ae4a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 36 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
vlib/v/checker/fn.v
View File

@ -1543,8 +1543,11 @@ fn (mut c Checker) fn_call(mut node ast.CallExpr, mut continue_check &bool) ast.
} }
} }
arg_typ_sym := c.table.sym(arg_typ) arg_typ_sym := c.table.sym(arg_typ)
if arg_typ_sym.kind == .none && param.typ.has_flag(.generic) && !param.typ.has_flag(.option) { if param.typ.has_flag(.generic) {
c.error('cannot use `none` as generic argument', call_arg.pos) if arg_typ_sym.kind == .none && !param.typ.has_flag(.option) {
c.error('cannot use `none` as generic argument', call_arg.pos)
}
c.check_unresolved_generic_param(node, call_arg)
} }
param_typ_sym := c.table.sym(param.typ) param_typ_sym := c.table.sym(param.typ)
if func.is_variadic && arg_typ.has_flag(.variadic) && args_len - 1 > i { if func.is_variadic && arg_typ.has_flag(.variadic) && args_len - 1 > i {
@ -2573,6 +2576,7 @@ fn (mut c Checker) method_call(mut node ast.CallExpr, mut continue_check &bool)
} }
} }
if exp_arg_typ.has_flag(.generic) { if exp_arg_typ.has_flag(.generic) {
c.check_unresolved_generic_param(node, arg)
method_concrete_types := if method_generic_names_len == rec_concrete_types.len { method_concrete_types := if method_generic_names_len == rec_concrete_types.len {
rec_concrete_types rec_concrete_types
} else { } else {
@ -2753,6 +2757,13 @@ fn (mut c Checker) handle_generic_lambda_arg(node &ast.CallExpr, mut lambda ast.
} }
} }
fn (mut c Checker) check_unresolved_generic_param(node &ast.CallExpr, arg ast.CallArg) {
if node.raw_concrete_types.len == 0 && arg.expr is ast.ArrayInit
&& arg.expr.typ == ast.void_type {
c.error('cannot use empty array as generic argument', arg.pos)
}
}
fn (mut c Checker) spawn_expr(mut node ast.SpawnExpr) ast.Type { fn (mut c Checker) spawn_expr(mut node ast.SpawnExpr) ast.Type {
ret_type := c.call_expr(mut node.call_expr) ret_type := c.call_expr(mut node.call_expr)
if node.call_expr.or_block.kind != .absent { if node.call_expr.or_block.kind != .absent {

13
vlib/v/checker/tests/empty_arr_to_generic_param_err.out Normal file
View File

@ -0,0 +1,13 @@
vlib/v/checker/tests/empty_arr_to_generic_param_err.vv:8:4: error: cannot use empty array as generic argument
6 |
7 | fn main() {
8 | t([])
| ~~
9 | Foo{}.t([])
10 | }
vlib/v/checker/tests/empty_arr_to_generic_param_err.vv:9:10: error: cannot use empty array as generic argument
7 | fn main() {
8 | t([])
9 | Foo{}.t([])
| ~~
10 | }

10
vlib/v/checker/tests/empty_arr_to_generic_param_err.vv Normal file
View File

@ -0,0 +1,10 @@
fn t[T](a []T) {}
struct Foo {}
fn (t &Foo) t[T](a []T) {}
fn main() {
t([])
Foo{}.t([])
}