TheCloud/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2025-09-18 20:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

v.util: make launch_tool failures more detailed (for the Text file busy; code: 26 case), bump tool_recompile_retry_max_count from 3 to 7

Browse Source
This commit is contained in:
Delyan Angelov 2024-01-22 00:50:04 +02:00
parent 9f95ab7c5e
commit b42dd8bd06
No known key found for this signature in database
GPG Key ID: 66886C0F12D595ED
1 changed files with 25 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
vlib/v/util/util.v
View File

@ -4,6 +4,7 @@
module util module util
import os import os
import rand
import time import time
import v.pref import v.pref
import v.vmod import v.vmod
@ -176,8 +177,12 @@ pub fn launch_tool(is_verbose bool, tool_name string, args []string) {
} }
current_work_dir := os.getwd() current_work_dir := os.getwd()
retry_max_count := 3 // The goal of the random sleep intervals below, is to reduce the chance of a thundering herd, on `v test` with VJOBS>10,
for i in 0 .. retry_max_count { // when each compiled _test.c.v file could also need a recompilation of the js_builder in cmd/tools/builders/ .
// TODO: use the os.filelock's API for inter process coordination instead.
time.sleep((5 + rand.intn(15) or { 0 }) * time.millisecond)
tool_recompile_retry_max_count := 7
for i in 0 .. tool_recompile_retry_max_count {
// ensure a stable and known working folder, when compiling V's tools, to avoid module lookup problems: // ensure a stable and known working folder, when compiling V's tools, to avoid module lookup problems:
os.chdir(vroot) or {} os.chdir(vroot) or {}
tool_compilation := os.execute(compilation_command) tool_compilation := os.execute(compilation_command)
@ -185,25 +190,37 @@ pub fn launch_tool(is_verbose bool, tool_name string, args []string) {
if tool_compilation.exit_code == 0 { if tool_compilation.exit_code == 0 {
break break
} else { } else {
if i == retry_max_count - 1 { if i == tool_recompile_retry_max_count - 1 {
eprintln('cannot compile `${tool_source}`: \n${tool_compilation.output}') eprintln('cannot compile `${tool_source}`: ${tool_compilation.exit_code}\n${tool_compilation.output}')
exit(1) exit(1)
} }
time.sleep(20 * time.millisecond)
} }
time.sleep((20 + rand.intn(40) or { 0 }) * time.millisecond)
} }
} }
$if windows { $if windows {
exit(os.system('${os.quoted_path(tool_exe)} ${tool_args}')) cmd_system('${os.quoted_path(tool_exe)} ${tool_args}')
} $else $if js { } $else $if js {
// no way to implement os.execvp in JS backend // no way to implement os.execvp in JS backend
exit(os.system('${tool_exe} ${tool_args}')) cmd_system('${tool_exe} ${tool_args}')
} $else { } $else {
os.execvp(tool_exe, args) or { panic(err) } os.execvp(tool_exe, args) or {
eprintln('> error while executing: ${tool_exe} ${args}')
panic(err)
}
} }
exit(2) exit(2)
} }
@[noreturn]
fn cmd_system(cmd string) {
res := os.system(cmd)
if res != 0 {
eprintln('> error ${res}, while executing: ${cmd}')
}
exit(res)
}
// Note: should_recompile_tool/4 compares unix timestamps that have 1 second resolution // Note: should_recompile_tool/4 compares unix timestamps that have 1 second resolution
// That means that a tool can get recompiled twice, if called in short succession. // That means that a tool can get recompiled twice, if called in short succession.
// TODO: use a nanosecond mtime timestamp, if available. // TODO: use a nanosecond mtime timestamp, if available.