TheCloud/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2025-09-14 09:56:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

checker: cleanup in assign_stmt() (#20880)

Browse Source
This commit is contained in:
yuyi 2024-02-20 23:38:44 +08:00 committed by GitHub
parent 13fbf35f66
commit b83ce21cc7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
vlib/v/checker/assign.v
View File

@ -365,10 +365,11 @@ fn (mut c Checker) assign_stmt(mut node ast.AssignStmt) {
} }
} else if mut right is ast.Ident && right.obj is ast.Var } else if mut right is ast.Ident && right.obj is ast.Var
&& right.or_expr.kind == .absent { && right.or_expr.kind == .absent {
if (right.obj as ast.Var).ct_type_var != .no_comptime { right_obj_var := right.obj as ast.Var
if right_obj_var.ct_type_var != .no_comptime {
ctyp := c.comptime.get_comptime_var_type(right) ctyp := c.comptime.get_comptime_var_type(right)
if ctyp != ast.void_type { if ctyp != ast.void_type {
left.obj.ct_type_var = (right.obj as ast.Var).ct_type_var left.obj.ct_type_var = right_obj_var.ct_type_var
left.obj.typ = ctyp left.obj.typ = ctyp
} }
} }
@ -522,10 +523,9 @@ fn (mut c Checker) assign_stmt(mut node ast.AssignStmt) {
} }
} else if mut left is ast.Ident && left.kind != .blank_ident } else if mut left is ast.Ident && left.kind != .blank_ident
&& right is ast.IndexExpr { && right is ast.IndexExpr {
if (right as ast.IndexExpr).left is ast.Ident right_index_expr := right as ast.IndexExpr
&& (right as ast.IndexExpr).index is ast.RangeExpr if right_index_expr.left is ast.Ident && right_index_expr.index is ast.RangeExpr
&& ((right as ast.IndexExpr).left.is_mut() || left.is_mut()) && (right_index_expr.left.is_mut() || left.is_mut()) && !c.inside_unsafe {
&& !c.inside_unsafe {
// `mut a := arr[..]` auto add clone() -> `mut a := arr[..].clone()` // `mut a := arr[..]` auto add clone() -> `mut a := arr[..].clone()`
c.add_error_detail_with_pos('To silence this notice, use either an explicit `a[..].clone()`, c.add_error_detail_with_pos('To silence this notice, use either an explicit `a[..].clone()`,
or use an explicit `unsafe{ a[..] }`, if you do not want a copy of the slice.', or use an explicit `unsafe{ a[..] }`, if you do not want a copy of the slice.',