TheCloud/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2025-09-08 14:51:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

arrays: fix off by one error in arrays.uniq_only_repeated/1 and arrays.uniq_all_repeated/1

Browse Source
This commit is contained in:
Delyan Angelov 2023-12-04 15:21:01 +02:00
parent d9e9c71b29
commit c7b7d5f50f
No known key found for this signature in database
GPG Key ID: 66886C0F12D595ED
2 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
vlib/arrays/uniq.v
View File

@ -91,7 +91,7 @@ pub fn uniq_only_repeated[T](a []T) []T {
// found the right border of the repeated elements
if j - i > 1 {
res << a[i]
i = j
i = j - 1
continue loop
}
}
@ -132,7 +132,7 @@ pub fn uniq_all_repeated[T](a []T) []T {
for j := i + 1; j < a.len; j++ {
if a[i] != a[j] && j - i > 0 {
// found the right border of the repeated elements
i = j
i = j - 1
continue loop
}
res << a[i]

11
vlib/arrays/uniq_test.v
View File

@ -4,6 +4,8 @@ const a = [1, 5, 5, 1, 5, 2, 1, 1, 9, 2]
const s = [1, 1, 1, 1, 2, 2, 5, 5, 5, 9] // a.sorted()
const many_repeats = [1, 1, 1, 1, 2, 2, 5, 5, 5, 9, 1, 1, 9, 5, 5]
const astrings = ['b', 'b', 'a', 'b', 'z', 'a', 'a', 'd']
const sstrings = ['a', 'a', 'a', 'b', 'b', 'b', 'd', 'z'] // astrings.sorted()
@ -16,6 +18,7 @@ fn test_uniq() {
assert arrays.uniq(s) == [1, 2, 5, 9]
assert arrays.uniq(astrings) == ['b', 'a', 'b', 'z', 'a', 'd']
assert arrays.uniq(sstrings) == ['a', 'b', 'd', 'z']
assert arrays.uniq(many_repeats) == [1, 2, 5, 9, 1, 9, 5]
}
fn test_uniq_only() {
@ -27,6 +30,7 @@ fn test_uniq_only() {
assert arrays.uniq_only(s) == [9]
assert arrays.uniq_only(astrings) == ['a', 'b', 'z', 'd']
assert arrays.uniq_only(sstrings) == ['d', 'z']
assert arrays.uniq_only(many_repeats) == [9, 9]
}
fn test_uniq_only_repeated() {
@ -52,7 +56,8 @@ fn test_uniq_only_repeated() {
assert arrays.uniq_only_repeated([5, 5, 1, 5, 5, 2, 5, 5, 3, 5, 5]) == [5, 5, 5, 5]
assert arrays.uniq_only_repeated([5, 5, 5, 1, 5, 5, 2, 5, 5, 3, 5, 5]) == [5, 5, 5, 5]
assert arrays.uniq_only_repeated(a) == [5, 1]
assert arrays.uniq_only_repeated(s) == [1, 5]
assert arrays.uniq_only_repeated(s) == [1, 2, 5]
assert arrays.uniq_only_repeated(many_repeats) == [1, 2, 5, 1, 5]
}
fn test_uniq_all_repeated() {
@ -80,10 +85,12 @@ fn test_uniq_all_repeated() {
assert arrays.uniq_all_repeated([5, 5, 5, 1, 5, 5, 2, 5, 5, 3, 5, 5]) == [5, 5, 5, 5, 5, 5,
5, 5, 5]
assert arrays.uniq_all_repeated(a) == [5, 5, 1, 1]
assert arrays.uniq_all_repeated(s) == [1, 1, 1, 1, 5, 5, 5]
assert arrays.uniq_all_repeated(s) == [1, 1, 1, 1, 2, 2, 5, 5, 5]
assert arrays.uniq_all_repeated(many_repeats) == [1, 1, 1, 1, 2, 2, 5, 5, 5, 1, 1, 5, 5]
}
fn test_distinct() {
assert arrays.distinct(a) == arrays.distinct(s)
assert arrays.distinct(a) == [1, 2, 5, 9]
assert arrays.distinct(many_repeats) == [1, 2, 5, 9]
}