From ec8253236b44f2155e52e83a4401209b7bee9818 Mon Sep 17 00:00:00 2001 From: fekir Date: Tue, 22 Aug 2017 18:32:40 +0200 Subject: [PATCH] Remove virtual destructor since there are no virtual methods or subclasses --- include/SQLiteCpp/Backup.h | 2 +- include/SQLiteCpp/Column.h | 2 +- include/SQLiteCpp/Database.h | 2 +- include/SQLiteCpp/Statement.h | 2 +- include/SQLiteCpp/Transaction.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/SQLiteCpp/Backup.h b/include/SQLiteCpp/Backup.h index 5cc379d..9f54ada 100644 --- a/include/SQLiteCpp/Backup.h +++ b/include/SQLiteCpp/Backup.h @@ -100,7 +100,7 @@ public: Database& aSrcDatabase); /// Release the SQLite Backup resource. - virtual ~Backup(); + ~Backup(); /** * @brief Execute a step of backup with a given number of source pages to be copied diff --git a/include/SQLiteCpp/Column.h b/include/SQLiteCpp/Column.h index 1004fb9..1545b4f 100644 --- a/include/SQLiteCpp/Column.h +++ b/include/SQLiteCpp/Column.h @@ -54,7 +54,7 @@ public: */ Column(Statement::Ptr& aStmtPtr, int aIndex) noexcept; // nothrow /// Simple destructor - virtual ~Column(); + ~Column(); // default copy constructor and assignment operator are perfectly suited : // they copy the Statement::Ptr which in turn increments the reference counter. diff --git a/include/SQLiteCpp/Database.h b/include/SQLiteCpp/Database.h index 764a0c6..0f35ee1 100644 --- a/include/SQLiteCpp/Database.h +++ b/include/SQLiteCpp/Database.h @@ -127,7 +127,7 @@ public: * * @warning assert in case of error */ - virtual ~Database(); + ~Database(); /** * @brief Set a busy handler that sleeps for a specified amount of time when a table is locked. diff --git a/include/SQLiteCpp/Statement.h b/include/SQLiteCpp/Statement.h index 07ae972..b4f478a 100644 --- a/include/SQLiteCpp/Statement.h +++ b/include/SQLiteCpp/Statement.h @@ -73,7 +73,7 @@ public: Statement(Database& aDatabase, const std::string& aQuery); /// Finalize and unregister the SQL query from the SQLite Database Connection. - virtual ~Statement(); + ~Statement(); /// Reset the statement to make it ready for a new execution. void reset(); diff --git a/include/SQLiteCpp/Transaction.h b/include/SQLiteCpp/Transaction.h index cc50591..7e92a6d 100644 --- a/include/SQLiteCpp/Transaction.h +++ b/include/SQLiteCpp/Transaction.h @@ -55,7 +55,7 @@ public: /** * @brief Safely rollback the transaction if it has not been committed. */ - virtual ~Transaction(); + ~Transaction(); /** * @brief Commit the transaction.