cuberite/libevent
1
0
Fork 0
mirror of https://github.com/cuberite/libevent.git synced 2025-09-18 08:49:57 -04:00
Code Issues Packages Projects Releases Wiki Activity

Never call evhttp_readcb while writing.

Browse Source
This commit is contained in:
Nick Mathewson 2010-11-04 14:05:08 -04:00
parent c76640b5c2
commit 05124879d3
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
http.c
View File

@ -343,6 +343,15 @@ evhttp_write_buffer(struct evhttp_connection *evcon,
evcon->cb_arg = arg; evcon->cb_arg = arg;
bufferevent_enable(evcon->bufev, EV_WRITE); bufferevent_enable(evcon->bufev, EV_WRITE);
/* Disable the read callback: we don't actually care about data;
* we only care about close detection. (We don't disable reading,
* since we *do* want to learn about any close events.) */
bufferevent_setcb(evcon->bufev,
NULL, /*read*/
evhttp_write_cb,
evhttp_error_cb,
evcon);
} }
/** Helper: returns true iff evconn is in any connected state. */ /** Helper: returns true iff evconn is in any connected state. */
@ -2056,6 +2065,12 @@ evhttp_start_read(struct evhttp_connection *evcon)
bufferevent_disable(evcon->bufev, EV_WRITE); bufferevent_disable(evcon->bufev, EV_WRITE);
bufferevent_enable(evcon->bufev, EV_READ); bufferevent_enable(evcon->bufev, EV_READ);
evcon->state = EVCON_READING_FIRSTLINE; evcon->state = EVCON_READING_FIRSTLINE;
/* Reset the bufferevent callbacks */
bufferevent_setcb(evcon->bufev,
evhttp_read_cb,
evhttp_write_cb,
evhttp_error_cb,
evcon);
/* If there's still data pending, process it next time through the /* If there's still data pending, process it next time through the
* loop. Don't do it now; that could get recusive. */ * loop. Don't do it now; that could get recusive. */