fix an embarassing bug where strchr was used with a cstring instead of a char

svn:r383
This commit is contained in:
Niels Provos 2007-08-06 20:53:33 +00:00
parent 8ea5ffefc3
commit 073d359061
2 changed files with 10 additions and 2 deletions

7
http.c
View File

@ -1120,10 +1120,13 @@ int
evhttp_add_header(struct evkeyvalq *headers,
const char *key, const char *value)
{
struct evkeyval *header;
struct evkeyval *header = NULL;
if (strchr(value, "\r") != NULL || strchr(value, "\n") != NULL) {
event_debug(("%s: key: %s val: %s\n", __func__, key, value));
if (strchr(value, '\r') != NULL || strchr(value, '\n') != NULL) {
/* drop illegal headers */
event_debug(("%s: dropping illegal header\n"));
return (-1);
}

View File

@ -517,6 +517,11 @@ http_postrequest_done(struct evhttp_request *req, void *arg)
{
const char *what = "This is funny";
if (req == NULL) {
fprintf(stderr, "FAILED (timeout)\n");
exit(1);
}
if (req->response_code != HTTP_OK) {
fprintf(stderr, "FAILED (response code)\n");