cuberite/libevent
1
0
Fork 0
mirror of https://github.com/cuberite/libevent.git synced 2025-09-11 13:24:43 -04:00
Code Issues Packages Projects Releases Wiki Activity

test/dns: more graceful coverage of @fail_requests

Browse Source 
In case when evdns_base_free() called with @fail_requests, we can potentially
have leaks, but we can avoid them if we will run event loop once again to
trigger defer cbs, so let's do this, instead of magical decrements (and also
this will give an example how to avoid leaks for evdns).
This commit is contained in:
Azat Khuzhin 2015-11-23 15:14:32 +03:00
parent fdf713a08b
commit 123d372864
1 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
test/regress_dns.c
View File

@ -1902,29 +1902,22 @@ dbg_leak_resume(void *env_, int cancel, int send_err_shutdown)
tt_assert(!evdns_base_resume(env->dns_base));
}
event_base_loop(env->base, EVLOOP_NONBLOCK);
/**
* Because we don't cancel request,
* and want our callback to recieve DNS_ERR_SHUTDOWN,
* we use deferred callback, and there was
* Because we don't cancel request, and want our callback to recieve
* DNS_ERR_SHUTDOWN, we use deferred callback, and there was:
* - one extra malloc(),
* @see reply_schedule_callback()
* - and one missing free
* @see request_finished() (req->handle->pending_cb = 1)
* than we don't need to count in testleak_cleanup()
*
* So just decrement allocated_chunks to 2,
* like we already take care about it.
* than we don't need to count in testleak_cleanup(), but we can clean them
* if we will run loop once again, but *after* evdns base freed.
*/
if (!cancel && send_err_shutdown) {
allocated_chunks -= 2;
}
evdns_base_free(env->dns_base, send_err_shutdown);
env->dns_base = 0;
event_base_loop(env->base, EVLOOP_NONBLOCK);
end:
evdns_base_free(env->dns_base, send_err_shutdown);
env->dns_base = 0;
event_base_free(env->base);
env->base = 0;
}