From 1f50f412834c8b150a37bb5742f6702537093d52 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Wed, 7 Nov 2007 07:33:26 +0000 Subject: [PATCH] r16508@catbus: nickm | 2007-11-07 02:01:03 -0500 Note a dubious point in http.c svn:r496 --- http.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/http.c b/http.c index d190f0c4..c11df8e9 100644 --- a/http.c +++ b/http.c @@ -422,6 +422,8 @@ evhttp_make_header(struct evhttp_connection *evcon, struct evhttp_request *req) } evbuffer_add(evcon->output_buffer, "\r\n", 2); + /* XXX EVBUFFER_LENGTH returns an unsigned value, so this test + * is always true. What is the intent of this test? -NM */ if (EVBUFFER_LENGTH(req->output_buffer) >= 0) { /* * For a request, we add the POST data, for a reply, this